search

Vonage / vonage-python-sdk

Vonage Server SDK for Python. API support for Voice, SMS, WhatsApp, Verify (2FA), Video Meetings and more.
https://developer.vonage.com
Apache License 2.0
194 stars 118 forks source link

Video beta #224

Closed maxkahan closed 2 years ago

maxkahan commented 2 years ago

This is a draft PR showing the new Vonage Video API implementation

codecov-commenter commented 2 years ago

Codecov Report

Merging #224 (8ae644e) into main (e37ce44) will increase coverage by 0.69%. The diff coverage is 100.00%.

@@            Coverage Diff             @@
##             main     #224      +/-   ##
==========================================
+ Coverage   97.44%   98.13%   +0.69%     
==========================================
  Files          15       16       +1     
  Lines         469      591     +122     
==========================================
+ Hits          457      580     +123     
+ Misses         12       11       -1
Impacted Files Coverage Δ
src/vonage/client.py 96.55% <100.00%> (+0.27%) :arrow_up:
src/vonage/errors.py 100.00% <100.00%> (ø)
src/vonage/video.py 100.00% <100.00%> (ø)
src/vonage/messages.py 100.00% <0.00%> (+1.88%) :arrow_up:

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

pardel commented 2 years ago

@maxkahan Please do not merge this into main but maintain a separate branch for now.

maxkahan commented 2 years ago

@dragonmantank Have made your suggested changes

maxkahan commented 2 years ago

Thanks Chris! As discussed, I will keep this branch as the beta branch for video and release from here, so will now close this PR.