search

Vonage / vonage-python-sdk

Vonage Server SDK for Python. API support for Voice, SMS, WhatsApp, Verify (2FA), Video Meetings and more.
https://developer.vonage.com
Apache License 2.0
195 stars 118 forks source link

'Client' object has no attribute '_application_id' #227

Closed alexei closed 2 years ago

alexei commented 2 years ago

It appears the application ID is optional and the property itself is set conditionally: https://github.com/Vonage/vonage-python-sdk/blob/c577aa7f110f8297fd2a6d66f75179fcdd2f9de8/src/vonage/client.py#L97-L99 But later, when sending a message, the code assumes the property exists: https://github.com/Vonage/vonage-python-sdk/blob/c577aa7f110f8297fd2a6d66f75179fcdd2f9de8/src/vonage/messages.py#L19-L29 Hence the error in the title.

maxkahan commented 2 years ago

Hi @alexei, thanks for raising this. I'll push a fix and make a patch release 🙂

maxkahan commented 2 years ago

Have made PR #228. Will close this issue when merged.

alexei commented 2 years ago

👍