search

Vonage / vonage-python-sdk

Vonage Server SDK for Python. API support for Voice, SMS, WhatsApp, Verify (2FA), Video Meetings and more.
https://developer.vonage.com
Apache License 2.0
192 stars 118 forks source link

Add ni v2 #265

Closed maxkahan closed 3 months ago

maxkahan commented 1 year ago

Adds Number Insight v2 functionality Refactors regex checks into one function in the _internal.py module

codecov-commenter commented 1 year ago

Codecov Report

Merging #265 (57426aa) into main (c57adff) will increase coverage by 0.00%. The diff coverage is 98.03%.

@@           Coverage Diff           @@
##             main     #265   +/-   ##
=======================================
  Coverage   97.33%   97.34%           
=======================================
  Files          25       26    +1     
  Lines        1090     1129   +39     
=======================================
+ Hits         1061     1099   +38     
- Misses         29       30    +1
Files Changed Coverage Δ
src/vonage/number_insight_v2.py 96.00% <96.00%> (ø)
src/vonage/_internal.py 95.23% <100.00%> (+2.93%) :arrow_up:
src/vonage/client.py 94.29% <100.00%> (+0.05%) :arrow_up:
src/vonage/errors.py 100.00% <100.00%> (ø)
src/vonage/messages.py 100.00% <100.00%> (ø)
src/vonage/verify2.py 98.38% <100.00%> (-0.03%) :arrow_down:

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

maxkahan commented 1 year ago

@superchilled Have made your suggested changes 🙂

maxkahan commented 3 months ago

Closing as adding in v4 and the current functionality will be added to Number Insight v1 in a similar form.