Vonage / vonage-python-sdk

Vonage Server SDK for Python. API support for Voice, SMS, WhatsApp, Verify (2FA), Video Meetings and more.
https://developer.vonage.com
Apache License 2.0
193 stars 118 forks source link

Attempt to upgrade to pydantic 2 #291

Closed DomThePorcupine closed 11 months ago

DomThePorcupine commented 11 months ago

I missed that someone else already had a PR open for this :( but I did manage to get all the tests passing with minimal changes, so I'm opening this in case it's helpful :)

DomThePorcupine commented 11 months ago

My apologies I was running make test which disables the warnings :(

I was able to go through and address all the pydantic deprecations. I think it's much better now!

Let me know if there's anything else you need

maxkahan commented 11 months ago

Hi @DomThePorcupine this is awesome, thanks for working on the changes so quickly. Just the one test you commented out that we should have back in, but everything else is looking great! 🙂

DomThePorcupine commented 11 months ago

Whoops! That was embarrassing, thanks for catching that :)

maxkahan commented 11 months ago

Think I found all the parts that needed changing, but it's probably wise to double check