Vonage / vonage-ruby-sdk

Vonage REST API client for Ruby. API support for SMS, Voice, Text-to-Speech, Numbers, Verify (2FA) and more.
https://developer.vonage.com
Apache License 2.0
217 stars 108 forks source link

DEVX-5545: Update Voice#create to better support random_from_number #225

Closed superchilled closed 2 years ago

superchilled commented 2 years ago

Reason for this PR

To improve support for usage of a random number from a pool with the Voice API

What this PR does

codecov-commenter commented 2 years ago

Codecov Report

Merging #225 (400716b) into dev (0a31c25) will increase coverage by 0.00%. The diff coverage is 100.00%.

:exclamation: Current head 400716b differs from pull request most recent head e591508. Consider uploading reports for the commit e591508 to get more accurate results

@@           Coverage Diff           @@
##              dev     #225   +/-   ##
=======================================
  Coverage   97.68%   97.69%           
=======================================
  Files          70       70           
  Lines        1384     1388    +4     
=======================================
+ Hits         1352     1356    +4     
  Misses         32       32           
Impacted Files Coverage Δ
lib/vonage/voice.rb 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 0a31c25...e591508. Read the comment docs.