Closed superchilled closed 2 years ago
Merging #236 (a8a8995) into dev (e4e4f79) will increase coverage by
0.02%
. The diff coverage is100.00%
.
@@ Coverage Diff @@
## dev #236 +/- ##
==========================================
+ Coverage 97.69% 97.71% +0.02%
==========================================
Files 70 70
Lines 1388 1401 +13
==========================================
+ Hits 1356 1369 +13
Misses 32 32
Impacted Files | Coverage Δ | |
---|---|---|
lib/vonage/namespace.rb | 100.00% <ø> (ø) |
|
lib/vonage/numbers.rb | 100.00% <100.00%> (ø) |
Help us with your feedback. Take ten seconds to tell us how you rate us.
Reason for this PR
To fix a bug when setting the
auto_advance
parameter totrue
when making requests with theNumbers
classlist
andsearch
methods.The cause of this bug was that auto advance relied on the
Namespace#iterable_request
, the implementation of which didn't work for the Numbers API because responses from that API don't include arecord_index
value.What this PR does
iterable_request
in theNumbers
class which over-rides the version inNamespace
.