Closed superchilled closed 2 years ago
Merging #241 (7091849) into dev (4169c8a) will not change coverage. The diff coverage is
n/a
.:exclamation: Current head 7091849 differs from pull request most recent head 5973806. Consider uploading reports for the commit 5973806 to get more accurate results
@@ Coverage Diff @@
## dev #241 +/- ##
=======================================
Coverage 97.71% 97.71%
=======================================
Files 70 70
Lines 1401 1401
=======================================
Hits 1369 1369
Misses 32 32
:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more
LGTM
@dragonmantank GitHub is saying that you requested changes, but I can't see what.
Reason for this PR
The Verify API has a new possible error response for the
https://api.nexmo.com/verify/json
, which can return a response with and without certain properties in the response body. This PR is to ensure that the existing implementation of Verify in the Ruby SDK handles the various permutations of this response correctly. See this JIRA ticket for additional context.What this PR does
verify_test.rb
:network
but notrequest_id
request_id
but notnetwork
request_id
andnetwork