search

Vonage / vonage-ruby-sdk

Vonage REST API client for Ruby. API support for SMS, Voice, Text-to-Speech, Numbers, Verify (2FA) and more.
https://developer.vonage.com
Apache License 2.0
217 stars 108 forks source link

DEVX-6617: Update gemspec JWT dependency and Supported versions #251

Closed superchilled closed 1 year ago

superchilled commented 1 year ago
codecov-commenter commented 1 year ago

Codecov Report

Merging #251 (61675b2) into dev (099e925) will not change coverage. The diff coverage is 100.00%.

@@           Coverage Diff           @@
##              dev     #251   +/-   ##
=======================================
  Coverage   97.73%   97.73%           
=======================================
  Files          71       71           
  Lines        1457     1457           
=======================================
  Hits         1424     1424           
  Misses         33       33
Impacted Files Coverage Δ
lib/vonage/jwt.rb 100.00% <100.00%> (ø)

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more

SecondeJK commented 1 year ago

I hope that token is all good!

superchilled commented 1 year ago

I hope that token is all good!

Yep. I had to update the hard-coded token because the new JWT library includes typ and alg in the header rather than the payload, so the encoding is different. I've double checked it to make sure it decodes correctly.