Closed superchilled closed 1 year ago
Merging #261 (e03165f) into dev (1e33d4c) will increase coverage by
0.21%
. The diff coverage is99.52%
.:exclamation: Current head e03165f differs from pull request most recent head d989a61. Consider uploading reports for the commit d989a61 to get more accurate results
@@ Coverage Diff @@
## dev #261 +/- ##
==========================================
+ Coverage 97.73% 97.95% +0.21%
==========================================
Files 71 81 +10
Lines 1457 1660 +203
==========================================
+ Hits 1424 1626 +202
- Misses 33 34 +1
Impacted Files | Coverage Δ | |
---|---|---|
lib/vonage/namespace.rb | 100.00% <ø> (ø) |
|
lib/vonage/verify2/workflow.rb | 93.75% <93.75%> (ø) |
|
lib/vonage/client.rb | 100.00% <100.00%> (ø) |
|
lib/vonage/messaging/channels/viber.rb | 100.00% <100.00%> (ø) |
|
lib/vonage/messaging/channels/whats_app.rb | 100.00% <100.00%> (ø) |
|
lib/vonage/numbers.rb | 100.00% <100.00%> (ø) |
|
lib/vonage/verify2.rb | 100.00% <100.00%> (ø) |
|
lib/vonage/verify2/channels/email.rb | 100.00% <100.00%> (ø) |
|
lib/vonage/verify2/channels/silent_auth.rb | 100.00% <100.00%> (ø) |
|
lib/vonage/verify2/channels/sms.rb | 100.00% <100.00%> (ø) |
|
... and 5 more |
:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more
Note: waiting to merge this until the product is GA.
What this PR does
Implements the Verify v2 API in the Ruby SDK by doing the following:
Verify2
class with the following methods:start_verification
: starts a verification requestcheck_code
checks a code against a specificverification_id
cancel_verification_request
cancels an active verification request via a specificverification_id
start_verification_options
: instantiates aStartVerificationOptions
objectworkflow
: instantiates aWorkflow
objectworkflow_builder
: returns theWorkflowBuilder
classStartVerificationOptions
Workflow
WorkflowBuilder
Vonage:Client
class to add averify2
method (which instantiates a newVerify2
object, or returns an existing one if already created)Vonage::Namespace#parse
method to account for the fact that the Verify v2 API code check endpoint returns a HTTP response with a200
status but no bodyREADME
document to outline how to use the added functionality