search

Vonage / vonage-ruby-sdk

Vonage REST API client for Ruby. API support for SMS, Voice, Text-to-Speech, Numbers, Verify (2FA) and more.
https://developer.vonage.com
Apache License 2.0
216 stars 108 forks source link

DEVX-7131: Updating Numbers implementation to use Basic auth #262

Closed superchilled closed 1 year ago

superchilled commented 1 year ago

This PR does the following:

codecov-commenter commented 1 year ago

Codecov Report

Merging #262 (bba8e7f) into dev (69e0e7a) will increase coverage by 0.01%. The diff coverage is 100.00%.

:exclamation: Current head bba8e7f differs from pull request most recent head 62f1acd. Consider uploading reports for the commit 62f1acd to get more accurate results

@@            Coverage Diff             @@
##              dev     #262      +/-   ##
==========================================
+ Coverage   97.73%   97.74%   +0.01%     
==========================================
  Files          71       71              
  Lines        1457     1464       +7     
==========================================
+ Hits         1424     1431       +7     
  Misses         33       33
Impacted Files Coverage Δ
lib/vonage/sms.rb 100.00% <ø> (ø)
lib/vonage/gsm7.rb 100.00% <100.00%> (ø)
lib/vonage/messaging/channels/viber.rb 100.00% <100.00%> (ø)
lib/vonage/messaging/channels/whats_app.rb 100.00% <100.00%> (ø)
lib/vonage/numbers.rb 100.00% <100.00%> (ø)
lib/vonage/signature.rb 100.00% <100.00%> (ø)

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more