Vonage / vonage-ruby-sdk

Vonage REST API client for Ruby. API support for SMS, Voice, Text-to-Speech, Numbers, Verify (2FA) and more.
https://developer.vonage.com
Apache License 2.0
216 stars 108 forks source link

DEVX-6461: Improving Exceptions for API Errors #287

Closed superchilled closed 11 months ago

superchilled commented 11 months ago

This PR:

codecov-commenter commented 11 months ago

Codecov Report

Merging #287 (fc6470b) into main (44f2bb6) will decrease coverage by 0.03%. The diff coverage is 94.87%.

:exclamation: Current head fc6470b differs from pull request most recent head 5aadc81. Consider uploading reports for the commit 5aadc81 to get more accurate results

@@            Coverage Diff             @@
##             main     #287      +/-   ##
==========================================
- Coverage   97.96%   97.93%   -0.03%     
==========================================
  Files         107      108       +1     
  Lines        1967     1988      +21     
==========================================
+ Hits         1927     1947      +20     
- Misses         40       41       +1     
Files Changed Coverage Δ
lib/vonage.rb 91.66% <ø> (ø)
lib/vonage/errors.rb 94.44% <88.23%> (-2.70%) :arrow_down:
lib/vonage/api_error.rb 100.00% <100.00%> (ø)
lib/vonage/client_error.rb 100.00% <100.00%> (ø)
lib/vonage/server_error.rb 100.00% <100.00%> (ø)

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more