search

Vonage / vonage-ruby-sdk

Vonage REST API client for Ruby. API support for SMS, Voice, Text-to-Speech, Numbers, Verify (2FA) and more.
https://developer.vonage.com
Apache License 2.0
216 stars 108 forks source link

DEVX-7758: Remove Validation for Verify2 Locales #289

Closed superchilled closed 10 months ago

superchilled commented 10 months ago

Removes validation from the Verify2::StartVerificationOptions#locale= setter in order to enable the setting of any new locales that have been added to the API, or may be added in the future.

superchilled commented 10 months ago

~WIP. Don't merge.~

codecov-commenter commented 10 months ago

Codecov Report

Merging #289 (233a29b) into main (8086a92) will decrease coverage by 0.01%. The diff coverage is n/a.

:exclamation: Current head 233a29b differs from pull request most recent head 6522823. Consider uploading reports for the commit 6522823 to get more accurate results

@@            Coverage Diff             @@
##             main     #289      +/-   ##
==========================================
- Coverage   97.94%   97.93%   -0.01%     
==========================================
  Files         108      108              
  Lines        1991     1988       -3     
==========================================
- Hits         1950     1947       -3     
  Misses         41       41
Files Coverage Δ
lib/vonage/verify2/start_verification_options.rb 100.00% <ø> (ø)

:mega: We’re building smart automated test selection to slash your CI/CD build times. Learn more