Vonng / pg_exporter

Advanced PostgreSQL & Pgbouncer Metrics Exporter for Prometheus
https://pigsty.io
Apache License 2.0
164 stars 42 forks source link

Built-in metrics definition #11

Open Vonng opened 3 years ago

Vonng commented 3 years ago

Embed a default metrics definition into pg_exporter which support PG 10 - 14.

mjf commented 2 years ago

Please, remove UTF-8 drawing characters (and other weird characters) from literary everywhere in configuration and either replace them with ASCII +-| if you insist on the borders, line, frames etc. or perhaps consider reformating the documentation comments as something like plain Markdown or so... It also bloats the binary and I never understood this "trend" to include "configuration generators" directly in the software. :-1: Would this me possible, please? Thank you.


The exact reason why I would really like you to clean this up is that it caused some issues on some systems (the daemon refused to start) and I had to do semi-manual cleanup of the default configuration (prolonged painful utilization of step-by-step sed -i until the files vere clean-enough for daemon to start and then addition manual "polishing" and reformating because the files, of course, got messed up).

P.S. I can do the clean up for you if you liked but I must be sure the PR would be accepted. Otherwise I am not interested to spend the time on it. :slightly_smiling_face:

Vonng commented 2 years ago