search

Vonng / pg_exporter

Advanced PostgreSQL & Pgbouncer Metrics Exporter for Prometheus
https://pigsty.io
Apache License 2.0
164 stars 42 forks source link

TLS/SSL support #24

Closed keithf4 closed 9 months ago

keithf4 commented 2 years ago

Are there any plans for the exporter output to have TLS/SSL support? Just looking through docs and didn't see it mentioned.

keithf4 commented 2 years ago

Looking at node_exporter (and also a recent commit of postgres_exporter), it looks like they use this toolkit to add in support for TLS and web auth

https://github.com/prometheus/exporter-toolkit

https://github.com/prometheus/exporter-toolkit/tree/master/web

Vonng commented 2 years ago

Thanks for your feedback.

It is a reasonable feature (though I didn't use that in production...)

I'll try adding some sort of basic ssl support in next minor release.

Looking at node_exporter (and also a recent commit of postgres_exporter), it looks like they use this toolkit to add in support for TLS and web auth

https://github.com/prometheus/exporter-toolkit

https://github.com/prometheus/exporter-toolkit/tree/master/web

keithf4 commented 1 year ago

Just curious if this feature is in the works at all? It's honestly one of the only things holding us back from using it as TLS is a strict requirement in some of our environments.

Tried seeing about adding it myself, but honestly above my level of go expertise. So I realize it's not as easy as it looks.

Vonng commented 9 months ago

Now using the new prometheus client_golang & exporter-kit library to support TLS. released on 0.6.0