search

VoodooSMBus / VoodooRMI

Synaptic Trackpad driver over SMBus/I2C for macOS
GNU General Public License v2.0
233 stars 19 forks source link

Only add/remove interrupts during startup/shutdown #105

Closed 1Revenger1 closed 3 years ago

1Revenger1 commented 3 years ago

Removing/adding interrupts during sleep can cause issues with pinning on newer Cannonlake devices. These changes come from https://github.com/VoodooI2C/VoodooI2CHID/commit/9b12ce5e79a4139d125489a3e76b8fedc8fbd337, and make sense to me.

I would like someone to verify that this works and doesn't cause any panics when loading/unloading the kext.

@zhen-zen would you mind taking a look at this?

zhen-zen commented 3 years ago

That looks good to me. Just disabling the interrupt source should be enough. I can unload the kext in Big Sur, but don't have other testing environment right now. Maybe removing some trailing spaces?