VoodooSMBus / VoodooRMI

Synaptic Trackpad driver over SMBus/I2C for macOS
GNU General Public License v2.0
233 stars 19 forks source link

Apply scroll resolution #25

Closed gimdh closed 4 years ago

gimdh commented 4 years ago

I applied suggested code snippet in #22 and it feels a little smoother. Not sure if it's as good as VoodooPS2's implementation, though.

I found VoodooI2C development chat suggesting 2300 could be better than 800, but there was no difference for me. Also, their recent build uses 800 as default, so I opted for 800.

1Revenger1 commented 4 years ago

These values aren't going to affect the trackpoint as RMIBus isn't the IOService sending the values. Need to apply them to ButtonDevice/TrackpointDevice.

Also, we likely don't want to apply trackpad acceleration values to the trackpoint.

gimdh commented 4 years ago

Oh I see. There must have been some placebo. I'll place it correctly. By the way, VoodooPS2 applies Trackpad acceleration to Trackpoint, doesn't it?

1Revenger1 commented 4 years ago

@gimdh did you ever figure out the scroll resolution stuff? Was gonna close this otherwise.

gimdh commented 4 years ago

I decided to wait for 1.0 to before any work, and completely forgot about this. Thank you for reminding. I'll tinker a bit with VoodooTrackpoint to see if it's any better.

gimdh commented 4 years ago

I can confirm that code does work, but it's under VoodooTrackpoint's territory since major refactoring. Closing this PR, and moving to VoodooTrackpoint.