Linting with ruff - the PR that nobody asked for! - Githubissues

VorTECHsa / python-sdk

Vortexa DataScience SDK

https://vortechsa.github.io/python-sdk/

Apache License 2.0

21 stars 9 forks source link

Linting with ruff - the PR that nobody asked for! #503

Open SebastianoF opened 4 months ago

SebastianoF commented 4 months ago

CHANGELOG

Invasive, possibly annoying, or possibly useful PR that delegates all stuff related to linting to ruff

PROS

one linter to rule them all
way faster to run the pre-commit hook
easy to move forward maintaining the code
a bug fixed in a jupyter notebook calling pd and never importing it
a few code smell removed

CONS

That's a loooooong PR to review

TESTS

no test added or changed. The only change is the code formatting

COMMENTS

Please note that I do not have an API key, so I could run only the tests that do not need one. In case the CI/CD does not re run those tests please run the tests with the key manually before productionisation!

sonarcloud[bot] commented 3 months ago

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
2.1% Duplication on New Code

See analysis details on SonarCloud