search

VoronDesign / Voron-Tap

GNU General Public License v3.0
587 stars 103 forks source link

jlcpcb - Incorrect Part Placement? #59

Closed thijstriemstra closed 1 year ago

thijstriemstra commented 1 year ago

hi @tanaes I submitted the bom and placement files for an order at jlcpcb (my first) and uploaded the files provided in https://github.com/VoronDesign/Voron-Tap/tree/main/OptoTap/Tap_Photosensor_PCB_v2/jlcpcb/production_files

They came back with the following issue though, so it seems the PCB placement is off or I did something wrong..

Their feedback:

Since we are not so sure about the polarities of the components D1 are correct or not. Could you please kindly check if the polarities and placements of the components are correct in the below picture? Is it okay to proceed with production?

jlcpcb feedback

smt top

sm original

thijstriemstra commented 1 year ago

Since we are not so sure about the polarities of the components D1 are correct or not. Could you please kindly check if the polarities and placements of the components are correct in the below picture? Is it okay to proceed with production?

I opened the Tap_Photosensor_PCB.kicad_pro file in KiCad 7.0 and it shows the following schematic for D1:

schematic1 schematic2

I guess these images should be enough info for them to answer their question about D1, but I'll also include a link to the kicad files.

tanaes commented 1 year ago

The positive terminal should be in the upper left of the footprint in that picture — their “corrected” part is upside down.

thijstriemstra commented 1 year ago

thanks for the feedback @tanaes. they returned with something that seems to be exactly the same as before so I'll have to explain it again to them:

image

An updated/correct zip for jcplb that I can upload would be great..

tanaes commented 1 year ago

That is incorrect -- D1 should be rotated 180°. Pin 1 should be in the upper right corner, as denoted by the corner mark in the silkscreen.

On April 29, 2023, Github Notifications @.***> wrote:

thanks for the feedback @tanaes https://github.com/tanaes. they returned with:

  — Reply to this email directly, view it on GitHub https://github.com/VoronDesign/Voron-Tap/issues/59#issuecomment- 1528886832, or unsubscribe https://github.com/notifications/unsubscribe- auth/AB7ISADFZ7RXZ4OOL2V2PDLXDWI7XANCNFSM6AAAAAAXGGLK3I. You are receiving this because you were mentioned.Message ID: @.***>

thijstriemstra commented 1 year ago

IMG_4926

thanks @tanaes, they came back with this, and it looks ok now right?

tanaes commented 1 year ago

That is correct!

On May 4, 2023, Github Notifications @.***> wrote:

thanks @tanaes https://github.com/tanaes, they came back with this, and it looks ok now right?

— Reply to this email directly, view it on GitHub https://github.com/VoronDesign/Voron-Tap/issues/59#issuecomment- 1534679256, or unsubscribe https://github.com/notifications/unsubscribe- auth/AB7ISADPAQJN5DDBKJCORGLXEONUNANCNFSM6AAAAAAXGGLK3I. You are receiving this because you were mentioned.Message ID: @.***>

thijstriemstra commented 1 year ago

thanks for the help, the production started. how can we prevent this from happening to other users, it seems the jlcpcb .zip files in the repository produce incorrect jlcpcb instructions? can they be updated? im not sure how because i don't see an export to zip function in the jlcpcb interface.. how did you export these zip files?

tanaes commented 1 year ago

initially I think JLCPCB had incorrect pin numbering for this part in their system, so what would happen is the original automated placement would be correct but then they would go back and manually 'fix' it to be backwards. My guess is that they have updated their database but that has broken the rotation for that part in the file. I will need to re- export and check again.

On May 4, 2023, Github Notifications @.***> wrote:

thanks for the help, the production started. how can we prevent this from happening to other users, it seems the jlcpcb .zip files in the repository produce incorrect jlcpcb instructions? can they updated? im not sure how because i don't see an export to zip function in the jlcpcb interface..

— Reply to this email directly, view it on GitHub https://github.com/VoronDesign/Voron-Tap/issues/59#issuecomment- 1535589639, or unsubscribe https://github.com/notifications/unsubscribe- auth/AB7ISAGNZ733DGNNNSPNBK3XERJ3ZANCNFSM6AAAAAAXGGLK3I. You are receiving this because you were mentioned.Message ID: @.***>

thijstriemstra commented 1 year ago

looks like this was fixed in https://github.com/VoronDesign/Voron-Tap/commit/e783ce8710ebc401b4b872ef84dd3216f443cf81, thanks!