VoronDesign / Voron-Tap

GNU General Public License v3.0
565 stars 102 forks source link

Placement of D1 LED on OptoTap v2.4 #76

Open jonesuki opened 1 year ago

jonesuki commented 1 year ago

I ordered OptoTap with the provided files (under OptoTap/Tap_Photosensor_PCB_v2/jlcpcb). The D1 LED are all placed upside down.

I contacted jlcpcb and they replied: "Thanks for reaching out and sorry if any trouble caused. Please kindly check the production file of this order in the attachment. For each order, we will make the production file and show it in Order history in a few hours after customers place the order. Customers can check it and if any problems, you can contact us in time. For this order, the placement on the board is the same as the production file. We also notice that in the silkscreen layer, there is an arrow pointing to the board edge, and our engineering team make the placement according to the silkscreen. If the placement is incorrect, would you consider modify the arrow orienation on the silkscreen layer for your next orders? Silkscreen is very important for engineers and workers, so we sincerely suggest customers to make it better. For these boards, if the placement is indeed not as you wish, could you try some resoldering on your side? Sincerely hope it will not cause you too much trouble."

I think they mean the white arrow on the silk screen is pointing downwards (to the board edge) and so should the arrow on D1 LED. This interpretation is just the opposite to the Voron team "...a little arrow that matches up with a corresponding arrow on the part".

Which one is the correct one or widely-accepted way of matching the component to the silk screen?

Screenshot 2023-07-25 at 23 43 54

Produce_DanZhi SMT_Snapshot Top 5305808A_Y7 SMT02304201211345 IMG_5697

Screenshot 2023-07-26 at 00 36 25
jonesuki commented 1 year ago

P.S. The PCB still works after I enable dark mode. But there is no way to test it before connecting it to MCU.

jonesuki commented 1 year ago

Further reply from JLCPCB: "We can notice that the arrow is placed at the side far from the board edge. But it points to the side close to the board edge. If you would like that the green arrow on D1 points towards the board center insteand of the board edge, you can put the arrow there, but it should be rotated 180 degree and points to the board center. "

This confirms JLCPCB interprets the arrow on D1 is placed so that its arrow pointing to the same direction as the white arrow on silk screen.

Is it feasible to change the silk screen to match the JLCPCB's interpretation?