search

VoronDesign / VoronUsers

Voron Community mods
https://mods.vorondesign.com
GNU General Public License v3.0
2.95k stars 1.86k forks source link

Pull Request for Universal Phone Mount - Voron 2.4r2 #1017

Closed AVieira-1 closed 7 months ago

AVieira-1 commented 8 months ago

Which mods are added by this PR?

Universal_Phone_Mount

How was it tested?

Printed in ASA and mounted on my Voron 2.4r2, tested with a Samsung A3, Samsung Galaxy mini and a Samsung A52. Working as intended with the appropriate files and for the phones I have available for testing.

Any background context you want to provide?

Screenshots (if appropriate)

⚠️⚠️PLEASE READ AND COMPLETE THE CHECKLIST BELOW⚠️⚠️

AVieira-1 commented 8 months ago

The jpg files here are huge, totalling almost 100MB just in images. Can you resize those?

Compressed the JPGs with hopefully minimal quality loss. Let me know if it's enough, should total around 5-6mb now.

Corrected the misspellings, sorry about those.

Removed the license file.

Fixed the image links, I had originally /Images/xx.jpg on my first pull but it wasn't working on this one so it got me confused. Works fine without the / at the start.

Thanks

MapleLeafMakers commented 8 months ago

Clever mod, and looks good to me!

github-actions[bot] commented 8 months ago

Hi, thank you for submitting your PR. Please find below the results of the automated PR checker:

Added/Changed mods detected in this PR:

Item Result Description/Error Printer compatibility
AVieira/Universal_Phone_Mount ✅ SUCCESS This mod allows the use of different smartphones or possibly... V2.4r2

Tool check results overview:

Tool ✅ ⚠️ ❌ 💀
Whitespace checker 60 0 0 0
Mod structure checker 1 0 0 0
STL corruption checker 25 0 0 0
STL rotation checker 19 6 0 0
Readme generator 1 0 0 0

Tool check results details:

SUCCESS: ✅ #### Whitespace checker | Item | Result | Reason | | --- | --- | --- | | AVieira/Universal_Phone_Mount/README.md | ✅ SUCCESS | | | AVieira/Universal_Phone_Mount/.metadata.yml | ✅ SUCCESS | | | AVieira/Universal_Phone_Mount/STLs/Guide_x2.stl | ✅ SUCCESS | | | AVieira/Universal_Phone_Mount/STLs/case_rear.stl | ✅ SUCCESS | | | AVieira/Universal_Phone_Mount/STLs/case_front.stl | ✅ SUCCESS | | | AVieira/Universal_Phone_Mount/STLs/Claw_bottom/[a]_claw_bottom_13.5mm.stl | ✅ SUCCESS | | | AVieira/Universal_Phone_Mount/STLs/Claw_bottom/[a]_claw_bottom_12.5mm.stl | ✅ SUCCESS | | | AVieira/Universal_Phone_Mount/STLs/Claw_bottom/[a]_claw_bottom_8.5mm.stl | ✅ SUCCESS | | | AVieira/Universal_Phone_Mount/STLs/Claw_bottom/[a]_claw_bottom_6.5mm.stl | ✅ SUCCESS | | | AVieira/Universal_Phone_Mount/STLs/Claw_bottom/[a]_claw_bottom_9.5mm.stl | ✅ SUCCESS | | | AVieira/Universal_Phone_Mount/STLs/Claw_bottom/[a]_claw_bottom_10.5mm.stl | ✅ SUCCESS | | | AVieira/Universal_Phone_Mount/STLs/Claw_bottom/[a]_claw_bottom_7.5mm.stl | ✅ SUCCESS | | | AVieira/Universal_Phone_Mount/STLs/Claw_bottom/[a]_claw_bottom_11.5mm.stl | ✅ SUCCESS | | | AVieira/Universal_Phone_Mount/STLs/Claw_top/[a]_claw_top_10.5mm.stl | ✅ SUCCESS | | | AVieira/Universal_Phone_Mount/STLs/Claw_top/[a]_claw_top_11.5mm.stl | ✅ SUCCESS | | | AVieira/Universal_Phone_Mount/STLs/Claw_top/[a]_claw_top_13.5mm.stl | ✅ SUCCESS | | | AVieira/Universal_Phone_Mount/STLs/Claw_top/[a]_claw_top_6.5mm.stl | ✅ SUCCESS | | | AVieira/Universal_Phone_Mount/STLs/Claw_top/[a]_claw_top_8.5mm.stl | ✅ SUCCESS | | | AVieira/Universal_Phone_Mount/STLs/Claw_top/[a]_claw_top_9.5mm.stl | ✅ SUCCESS | | | AVieira/Universal_Phone_Mount/STLs/Claw_top/[a]_claw_top_7.5mm.stl | ✅ SUCCESS | | | AVieira/Universal_Phone_Mount/STLs/Claw_top/[a]_claw_top_12.5mm.stl | ✅ SUCCESS | | | AVieira/Universal_Phone_Mount/STLs/Slider/slider_190mm.stl | ✅ SUCCESS | | | AVieira/Universal_Phone_Mount/STLs/Slider/slider_90mm.stl | ✅ SUCCESS | | | AVieira/Universal_Phone_Mount/STLs/Slider/slider_80mm.stl | ✅ SUCCESS | | | AVieira/Universal_Phone_Mount/STLs/Slider/slider_170mm.stl | ✅ SUCCESS | | | AVieira/Universal_Phone_Mount/STLs/Slider/slider_100mm.stl | ✅ SUCCESS | | | AVieira/Universal_Phone_Mount/STLs/Slider/slider_150mm.stl | ✅ SUCCESS | | | AVieira/Universal_Phone_Mount/CAD/case_rear.stp | ✅ SUCCESS | | | AVieira/Universal_Phone_Mount/CAD/Guide_x2.stp | ✅ SUCCESS | | | AVieira/Universal_Phone_Mount/CAD/case_front.stp | ✅ SUCCESS | | | AVieira/Universal_Phone_Mount/CAD/slider.stp | ✅ SUCCESS | | | AVieira/Universal_Phone_Mount/CAD/claw_bottom.stp | ✅ SUCCESS | | | AVieira/Universal_Phone_Mount/CAD/claw_top.stp | ✅ SUCCESS | | | AVieira/Universal_Phone_Mount/Images/Size.png | ✅ SUCCESS | | | AVieira/Universal_Phone_Mount/Images/CAD_Exploded.png | ✅ SUCCESS | | | AVieira/Universal_Phone_Mount/Images/Assembly_Mounted_With_Galaxy_A3.jpg | ✅ SUCCESS | | | AVieira/Universal_Phone_Mount/Images/Slider_Elastic_Main_Assembly.jpg | ✅ SUCCESS | | | AVieira/Universal_Phone_Mount/Images/248.png | ✅ SUCCESS | | | AVieira/Universal_Phone_Mount/Images/Back.jpg | ✅ SUCCESS | | | AVieira/Universal_Phone_Mount/Images/Full.jpg | ✅ SUCCESS | | | AVieira/Universal_Phone_Mount/Images/Slider_Inserts.jpg | ✅ SUCCESS | | | AVieira/Universal_Phone_Mount/Images/Assembly_Mounted.jpg | ✅ SUCCESS | | | AVieira/Universal_Phone_Mount/Images/Front_Inserts.jpg | ✅ SUCCESS | | | AVieira/Universal_Phone_Mount/Images/CAD_Clearence.png | ✅ SUCCESS | | | AVieira/Universal_Phone_Mount/Images/Samsung_Galaxy_Mini_S5570.jpg | ✅ SUCCESS | | | AVieira/Universal_Phone_Mount/Images/Elastic_Band.jpg | ✅ SUCCESS | | | AVieira/Universal_Phone_Mount/Images/246.png | ✅ SUCCESS | | | AVieira/Universal_Phone_Mount/Images/case_front.png | ✅ SUCCESS | | | AVieira/Universal_Phone_Mount/Images/Back_Inserts.jpg | ✅ SUCCESS | | | AVieira/Universal_Phone_Mount/Images/250.png | ✅ SUCCESS | | | AVieira/Universal_Phone_Mount/Images/Samsung_A3.jpg | ✅ SUCCESS | | | AVieira/Universal_Phone_Mount/Images/CAD_Clearence_2.png | ✅ SUCCESS | | | AVieira/Universal_Phone_Mount/Images/Slider_Elastic.jpg | ✅ SUCCESS | | | AVieira/Universal_Phone_Mount/Images/CAD_parts/mini12864_case_hinge.png | ✅ SUCCESS | | | AVieira/Universal_Phone_Mount/Images/CAD_parts/claw_bottom.png | ✅ SUCCESS | | | AVieira/Universal_Phone_Mount/Images/CAD_parts/case_front.png | ✅ SUCCESS | | | AVieira/Universal_Phone_Mount/Images/CAD_parts/guide_x2.png | ✅ SUCCESS | | | AVieira/Universal_Phone_Mount/Images/CAD_parts/case_rear.png | ✅ SUCCESS | | | AVieira/Universal_Phone_Mount/Images/CAD_parts/claw_top.png | ✅ SUCCESS | | | AVieira/Universal_Phone_Mount/Images/CAD_parts/slider.png | ✅ SUCCESS | | --- #### Mod structure checker | Item | Result | Reason | | --- | --- | --- | | AVieira/Universal_Phone_Mount | ✅ SUCCESS | | --- #### STL corruption checker | Item | Result | Number of STL fixes applicable | | --- | --- | --- | | Guide_x2.stl | ✅ SUCCESS | 0 | | case_rear.stl | ✅ SUCCESS | 0 | | case_front.stl | ✅ SUCCESS | 0 | | [a]_claw_bottom_13.5mm.stl | ✅ SUCCESS | 0 | | [a]_claw_bottom_12.5mm.stl | ✅ SUCCESS | 0 | | [a]_claw_bottom_8.5mm.stl | ✅ SUCCESS | 0 | | [a]_claw_bottom_6.5mm.stl | ✅ SUCCESS | 0 | | [a]_claw_bottom_9.5mm.stl | ✅ SUCCESS | 0 | | [a]_claw_bottom_10.5mm.stl | ✅ SUCCESS | 0 | | [a]_claw_bottom_7.5mm.stl | ✅ SUCCESS | 0 | | [a]_claw_bottom_11.5mm.stl | ✅ SUCCESS | 0 | | [a]_claw_top_10.5mm.stl | ✅ SUCCESS | 0 | | [a]_claw_top_11.5mm.stl | ✅ SUCCESS | 0 | | [a]_claw_top_13.5mm.stl | ✅ SUCCESS | 0 | | [a]_claw_top_6.5mm.stl | ✅ SUCCESS | 0 | | [a]_claw_top_8.5mm.stl | ✅ SUCCESS | 0 | | [a]_claw_top_9.5mm.stl | ✅ SUCCESS | 0 | | [a]_claw_top_7.5mm.stl | ✅ SUCCESS | 0 | | [a]_claw_top_12.5mm.stl | ✅ SUCCESS | 0 | | slider_190mm.stl | ✅ SUCCESS | 0 | | slider_90mm.stl | ✅ SUCCESS | 0 | | slider_80mm.stl | ✅ SUCCESS | 0 | | slider_170mm.stl | ✅ SUCCESS | 0 | | slider_100mm.stl | ✅ SUCCESS | 0 | | slider_150mm.stl | ✅ SUCCESS | 0 | --- #### STL rotation checker | Item | Result | Original orientation | Suggested orientation | | --- | --- | --- | --- | | [a]_claw_bottom_6.5mm.stl | ✅ SUCCESS | [](https://ik.imagekit.io/vorondesign/ci_1017/_a__claw_bottom_6.5mm_sKEIxNuS.png) | | | [a]_claw_bottom_8.5mm.stl | ✅ SUCCESS | [](https://ik.imagekit.io/vorondesign/ci_1017/_a__claw_bottom_8.5mm_ZcolnApZ.png) | | | [a]_claw_bottom_12.5mm.stl | ✅ SUCCESS | [](https://ik.imagekit.io/vorondesign/ci_1017/_a__claw_bottom_12.5mm_XNhdwDpw.png) | | | [a]_claw_bottom_13.5mm.stl | ✅ SUCCESS | [](https://ik.imagekit.io/vorondesign/ci_1017/_a__claw_bottom_13.5mm_JMdjmewv.png) | | | [a]_claw_bottom_9.5mm.stl | ✅ SUCCESS | [](https://ik.imagekit.io/vorondesign/ci_1017/_a__claw_bottom_9.5mm_Evieiekc.png) | | | case_rear.stl | ✅ SUCCESS | [](https://ik.imagekit.io/vorondesign/ci_1017/case_rear_DnSbVQHR.png) | | | [a]_claw_bottom_10.5mm.stl | ✅ SUCCESS | [](https://ik.imagekit.io/vorondesign/ci_1017/_a__claw_bottom_10.5mm_JwaVgLSk.png) | | | Guide_x2.stl | ✅ SUCCESS | [](https://ik.imagekit.io/vorondesign/ci_1017/Guide_x2_ZquewRAo.png) | | | [a]_claw_bottom_7.5mm.stl | ✅ SUCCESS | [](https://ik.imagekit.io/vorondesign/ci_1017/_a__claw_bottom_7.5mm_CMtPaYWL.png) | | | [a]_claw_top_10.5mm.stl | ✅ SUCCESS | [](https://ik.imagekit.io/vorondesign/ci_1017/_a__claw_top_10.5mm_QpShrabP.png) | | | [a]_claw_bottom_11.5mm.stl | ✅ SUCCESS | [](https://ik.imagekit.io/vorondesign/ci_1017/_a__claw_bottom_11.5mm_NMGFiyYu.png) | | | [a]_claw_top_11.5mm.stl | ✅ SUCCESS | [](https://ik.imagekit.io/vorondesign/ci_1017/_a__claw_top_11.5mm_CbTqiRCR.png) | | | [a]_claw_top_13.5mm.stl | ✅ SUCCESS | [](https://ik.imagekit.io/vorondesign/ci_1017/_a__claw_top_13.5mm_GpIVpHsN.png) | | | [a]_claw_top_6.5mm.stl | ✅ SUCCESS | [](https://ik.imagekit.io/vorondesign/ci_1017/_a__claw_top_6.5mm_XWXDnYrS.png) | | | case_front.stl | ✅ SUCCESS | [](https://ik.imagekit.io/vorondesign/ci_1017/case_front_oqVKuuGj.png) | | | [a]_claw_top_9.5mm.stl | ✅ SUCCESS | [](https://ik.imagekit.io/vorondesign/ci_1017/_a__claw_top_9.5mm_fxHNOugR.png) | | | [a]_claw_top_7.5mm.stl | ✅ SUCCESS | [](https://ik.imagekit.io/vorondesign/ci_1017/_a__claw_top_7.5mm_gdsZOSDk.png) | | | [a]_claw_top_12.5mm.stl | ✅ SUCCESS | [](https://ik.imagekit.io/vorondesign/ci_1017/_a__claw_top_12.5mm_jwDlGfTB.png) | | | [a]_claw_top_8.5mm.stl | ✅ SUCCESS | [](https://ik.imagekit.io/vorondesign/ci_1017/_a__claw_top_8.5mm_HGTmHGlf.png) | | ---
WARNING: ⚠️ #### STL rotation checker | Item | Result | Original orientation | Suggested orientation | | --- | --- | --- | --- | | slider_190mm.stl | ⚠️ WARNING | [](https://ik.imagekit.io/vorondesign/ci_1017/slider_190mm_WHCxfCDT.png) | [](https://ik.imagekit.io/vorondesign/ci_1017/slider_190mm_rotated_DlwGxAwW.png) | | slider_90mm.stl | ⚠️ WARNING | [](https://ik.imagekit.io/vorondesign/ci_1017/slider_90mm_uBEajRfu.png) | [](https://ik.imagekit.io/vorondesign/ci_1017/slider_90mm_rotated_hHPoZOqT.png) | | slider_150mm.stl | ⚠️ WARNING | [](https://ik.imagekit.io/vorondesign/ci_1017/slider_150mm_hAZCrnFT.png) | [](https://ik.imagekit.io/vorondesign/ci_1017/slider_150mm_rotated_IeEhLYfm.png) | | slider_80mm.stl | ⚠️ WARNING | [](https://ik.imagekit.io/vorondesign/ci_1017/slider_80mm_pudgOJQY.png) | [](https://ik.imagekit.io/vorondesign/ci_1017/slider_80mm_rotated_UQYvzASO.png) | | slider_100mm.stl | ⚠️ WARNING | [](https://ik.imagekit.io/vorondesign/ci_1017/slider_100mm_InmjNwnt.png) | [](https://ik.imagekit.io/vorondesign/ci_1017/slider_100mm_rotated_bnjdGlJj.png) | | slider_170mm.stl | ⚠️ WARNING | [](https://ik.imagekit.io/vorondesign/ci_1017/slider_170mm_cCcgjqbq.png) | [](https://ik.imagekit.io/vorondesign/ci_1017/slider_170mm_rotated_LlppkjYu.png) | ---
FAILURE: ❌
EXCEPTION: 💀

I am a 🤖, this comment was generated automatically!

Made with ❤️ by the VoronDesign GitHub Team

MapleLeafMakers commented 8 months ago

On closer inspection, I think I agree with the warnings detected by the STL checker, the slider parts would probably print better upside-down. though they both look perfectly printable to me.

AVieira-1 commented 8 months ago

On closer inspection, I think I agree with the warnings detected by the STL checker, the slider parts would probably print better upside-down. though they both look perfectly printable to me.

I oriented the sliders this way because there's an unchamfered lip on the elastic retainer meant to prevent the elastic band from sliding off before installing the claw. Would need supports to be printed if I flipped the part.

I agree that it's technically easier to bridge the smaller wholes instead of the retainer section but I'm not sure the AI is accounting for the unchamfered lip and support requirement.

Let me know if the changes are required, I can easily flip the parts and either chamfer the lip or place some supports.

MapleLeafMakers commented 8 months ago

No need to change it, I think that's fine. the bot isn't always right, and they should print perfectly as-is.