Closed DanKeeling closed 7 months ago
Hi, thank you for submitting your PR. Please find below the results of the automated PR checker:
Item | Result | Description/Error | Printer compatibility |
---|---|---|---|
dankeeling/CreativeLiveCameraMount | ✅ SUCCESS | A mod to provide a mount for the Creative Live! Camera that mounts... | V2.4r2, VT |
Tool | ✅ | ⚠️ | ❌ | 💀 |
---|---|---|---|---|
Whitespace checker | 8 | 0 | 0 | 0 |
Mod structure checker | 1 | 0 | 0 | 0 |
STL corruption checker | 0 | 0 | 0 | 0 |
STL rotation checker | 0 | 0 | 0 | 0 |
Readme generator | 1 | 0 | 0 | 0 |
I am a 🤖, this comment was generated automatically!
Made with ❤️ by the VoronDesign GitHub Team
Aha! We're missing a meta file that contains the information to merge the modification. If you have a look here https://github.com/VoronDesign/VoronUsers/wiki/How-to-build-a-metadata.yml-file you'll hopefully see what needs to go into that file
Aha! We're missing a meta file that contains the information to merge the modification. If you have a look here https://github.com/VoronDesign/VoronUsers/wiki/How-to-build-a-metadata.yml-file you'll hopefully see what needs to go into that file
I forgot to include that, it's been added in the branch now.
Looks like we're almost there! Thank you for sticking with it, we're learning a new system at the moment. One last thing that the automated test missed:
Can you rename Images/20231224_211032~2.jpg to not have the tilda, perhaps just use another underscore so that it conforms to:
All filenames and foldernames in VoronUsers must not have spaces in them! Please stick to letters a-zA-Z, numbers 0-9, underscores _, hyphens -, brackets []() and periods .
You will also need to update the link for it in the .metadata.yml and the README.MD file as well.
All good, new to this myself. Image has been renamed and references in Readme and metadata are updated to reflect the new name.
@dksub -- thank you for working with us as we work out the kinks in our new PR process. It is very much appreciated!
@DKsub -- thank you for working with us as we work out the kinks in our new PR process. It is very much appreciated!
All good, happy to be a tester and help the community.
Notice for other reviewers: my approval is not one from an exhaustive PR, I was just closing out my single comment that I somehow turned into a merge-stopping review.
Which mods are added by this PR?
Trident, 2.4, any with 20x20 extrusions with space
How was it tested?
Printed in 3 different orientations in ABS, found the best one and changed STL accordingly. Included in instructions with print settings
Any background context you want to provide?
I could not find a mount for the inexpensive web camera, so designed one in OnShape.
Screenshots (if appropriate)
Included in the repo.![292704824-28ee8aaa-a486-46c3-86b7-506ef56032f8](https://github.com/VoronDesign/VoronUsers/assets/5109514/a28e18c0-c208-4c3f-9004-4edd71c5cf2e)
⚠️⚠️PLEASE READ AND COMPLETE THE CHECKLIST BELOW⚠️⚠️