VoronDesign / VoronUsers

Voron Community mods
https://mods.vorondesign.com
GNU General Public License v3.0
2.95k stars 1.86k forks source link

Creative Live! Camera Mount #1018

Closed DanKeeling closed 7 months ago

DanKeeling commented 8 months ago

Which mods are added by this PR?

Trident, 2.4, any with 20x20 extrusions with space

How was it tested?

Printed in 3 different orientations in ABS, found the best one and changed STL accordingly. Included in instructions with print settings

Any background context you want to provide?

I could not find a mount for the inexpensive web camera, so designed one in OnShape.

Screenshots (if appropriate)

Included in the repo. 292704824-28ee8aaa-a486-46c3-86b7-506ef56032f8

⚠️⚠️PLEASE READ AND COMPLETE THE CHECKLIST BELOW⚠️⚠️

github-actions[bot] commented 8 months ago

Hi, thank you for submitting your PR. Please find below the results of the automated PR checker:

Added/Changed mods detected in this PR:

Item Result Description/Error Printer compatibility
dankeeling/CreativeLiveCameraMount ✅ SUCCESS A mod to provide a mount for the Creative Live! Camera that mounts... V2.4r2, VT

Tool check results overview:

Tool ⚠️ 💀
Whitespace checker 8 0 0 0
Mod structure checker 1 0 0 0
STL corruption checker 0 0 0 0
STL rotation checker 0 0 0 0
Readme generator 1 0 0 0

Tool check results details:

SUCCESS: ✅ #### Whitespace checker | Item | Result | Reason | | --- | --- | --- | | dankeeling/CreativeLiveCameraMount/README.md | ✅ SUCCESS | | | dankeeling/CreativeLiveCameraMount/.metadata.yml | ✅ SUCCESS | | | dankeeling/CreativeLiveCameraMount/CAD/Creative_Live_Camera_Mount.step | ✅ SUCCESS | | | dankeeling/CreativeLiveCameraMount/Images/20231224_211017.jpg | ✅ SUCCESS | | | dankeeling/CreativeLiveCameraMount/Images/20231224_211026.jpg | ✅ SUCCESS | | | dankeeling/CreativeLiveCameraMount/Images/PartImage.jpg | ✅ SUCCESS | | | dankeeling/CreativeLiveCameraMount/Images/20231224_211032_2.jpg | ✅ SUCCESS | | | dankeeling/CreativeLiveCameraMount/Images/20231224_211032.jpg | ✅ SUCCESS | | --- #### Mod structure checker | Item | Result | Reason | | --- | --- | --- | | dankeeling/CreativeLiveCameraMount | ✅ SUCCESS | | ---
WARNING: ⚠️
FAILURE: ❌
EXCEPTION: 💀

I am a 🤖, this comment was generated automatically!

Made with ❤️ by the VoronDesign GitHub Team

chirpy2605 commented 8 months ago

Aha! We're missing a meta file that contains the information to merge the modification. If you have a look here https://github.com/VoronDesign/VoronUsers/wiki/How-to-build-a-metadata.yml-file you'll hopefully see what needs to go into that file

DanKeeling commented 8 months ago

Aha! We're missing a meta file that contains the information to merge the modification. If you have a look here https://github.com/VoronDesign/VoronUsers/wiki/How-to-build-a-metadata.yml-file you'll hopefully see what needs to go into that file

I forgot to include that, it's been added in the branch now.

chirpy2605 commented 8 months ago

Looks like we're almost there! Thank you for sticking with it, we're learning a new system at the moment. One last thing that the automated test missed:

Can you rename Images/20231224_211032~2.jpg to not have the tilda, perhaps just use another underscore so that it conforms to:

All filenames and foldernames in VoronUsers must not have spaces in them! Please stick to letters a-zA-Z, numbers 0-9, underscores _, hyphens -, brackets []() and periods .

You will also need to update the link for it in the .metadata.yml and the README.MD file as well.

DanKeeling commented 8 months ago

All good, new to this myself. Image has been renamed and references in Readme and metadata are updated to reflect the new name.

bryanboettcher commented 7 months ago

@dksub -- thank you for working with us as we work out the kinks in our new PR process. It is very much appreciated!

DanKeeling commented 7 months ago

@DKsub -- thank you for working with us as we work out the kinks in our new PR process. It is very much appreciated!

All good, happy to be a tester and help the community.

bryanboettcher commented 7 months ago

Notice for other reviewers: my approval is not one from an exhaustive PR, I was just closing out my single comment that I somehow turned into a merge-stopping review.