search

VoronDesign / VoronUsers

Voron Community mods
https://mods.vorondesign.com
GNU General Public License v3.0
2.95k stars 1.86k forks source link

Add Rainbow Serial Bumper for Trident #1023

Closed MapleLeafMakers closed 7 months ago

MapleLeafMakers commented 7 months ago

Which mods are added by this PR?

Rainbow Serial Bumper for Voron Trident

How was it tested?

It's installed on my trident and functioning.

Any background context you want to provide?

"Rainbow" alludes to the RGB Nature of the mod, and "Bumper" is like a vehicle bumper...

Screenshots (if appropriate)

⚠️⚠️PLEASE READ AND COMPLETE THE CHECKLIST BELOW⚠️⚠️

mjonuschat commented 7 months ago

@MapleLeafMakers Your PR is missing a .metadata.yml file. Please see these instructions on how to create one and add it to your commit: https://github.com/VoronDesign/VoronUsers/wiki/How-to-build-a-metadata.yml-file

github-actions[bot] commented 7 months ago

Hi, thank you for submitting your PR. Please find below the results of the automated PR checker:

Added/Changed mods detected in this PR:

Item Result Description/Error Printer compatibility
MapleLeafMakers/Rainbow_Serial_Bumper ✅ SUCCESS Just a little bit of extra bling for your Voron Trident VT

Tool check results overview:

Tool ✅ ⚠️ ❌ 💀
Whitespace checker 23 0 0 0
Mod structure checker 1 0 0 0
STL corruption checker 4 0 0 0
STL rotation checker 2 2 0 0
Readme generator 1 0 0 0

Tool check results details:

SUCCESS: ✅ #### Whitespace checker | Item | Result | Reason | | --- | --- | --- | | MapleLeafMakers/Rainbow_Serial_Bumper/README.md | ✅ SUCCESS | | | MapleLeafMakers/Rainbow_Serial_Bumper/.metadata.yml | ✅ SUCCESS | | | MapleLeafMakers/Rainbow_Serial_Bumper/STL/[o]_back_plate.stl | ✅ SUCCESS | | | MapleLeafMakers/Rainbow_Serial_Bumper/STL/[o]_insert_collar.stl | ✅ SUCCESS | | | MapleLeafMakers/Rainbow_Serial_Bumper/STL/[a]_main_body.stl | ✅ SUCCESS | | | MapleLeafMakers/Rainbow_Serial_Bumper/STL/[oc]_insert.stl | ✅ SUCCESS | | | MapleLeafMakers/Rainbow_Serial_Bumper/CAD/Rainbow_Serial_Bumper.step | ✅ SUCCESS | | | MapleLeafMakers/Rainbow_Serial_Bumper/CAD/Rainbow_Serial_Bumper.f3d | ✅ SUCCESS | | | MapleLeafMakers/Rainbow_Serial_Bumper/Images/[oc]_insert_slicer_4.png | ✅ SUCCESS | | | MapleLeafMakers/Rainbow_Serial_Bumper/Images/thumbnail.png | ✅ SUCCESS | | | MapleLeafMakers/Rainbow_Serial_Bumper/Images/[oc]_insert_slicer_1.png | ✅ SUCCESS | | | MapleLeafMakers/Rainbow_Serial_Bumper/Images/[oc]_insert_slicer_5.png | ✅ SUCCESS | | | MapleLeafMakers/Rainbow_Serial_Bumper/Images/[a]_main_body.gif | ✅ SUCCESS | | | MapleLeafMakers/Rainbow_Serial_Bumper/Images/assembly_1.gif | ✅ SUCCESS | | | MapleLeafMakers/Rainbow_Serial_Bumper/Images/install.gif | ✅ SUCCESS | | | MapleLeafMakers/Rainbow_Serial_Bumper/Images/[o]_insert_collar_slicer.png | ✅ SUCCESS | | | MapleLeafMakers/Rainbow_Serial_Bumper/Images/[oc]_insert_slicer_3.png | ✅ SUCCESS | | | MapleLeafMakers/Rainbow_Serial_Bumper/Images/assembly_2.gif | ✅ SUCCESS | | | MapleLeafMakers/Rainbow_Serial_Bumper/Images/[o]_back_plate_slicer.png | ✅ SUCCESS | | | MapleLeafMakers/Rainbow_Serial_Bumper/Images/[oc]_insert_slicer_2.png | ✅ SUCCESS | | | MapleLeafMakers/Rainbow_Serial_Bumper/Images/tridentbling.gif | ✅ SUCCESS | | | MapleLeafMakers/Rainbow_Serial_Bumper/Images/[a]_main_body_slicer.png | ✅ SUCCESS | | | MapleLeafMakers/Rainbow_Serial_Bumper/Images/[o]_insert_collar.gif | ✅ SUCCESS | | --- #### Mod structure checker | Item | Result | Reason | | --- | --- | --- | | MapleLeafMakers/Rainbow_Serial_Bumper | ✅ SUCCESS | | --- #### STL corruption checker | Item | Result | Number of STL fixes applicable | | --- | --- | --- | | [o]_back_plate.stl | ✅ SUCCESS | 0 | | [o]_insert_collar.stl | ✅ SUCCESS | 0 | | [a]_main_body.stl | ✅ SUCCESS | 0 | | [oc]_insert.stl | ✅ SUCCESS | 0 | --- #### STL rotation checker | Item | Result | Original orientation | Suggested orientation | | --- | --- | --- | --- | | [o]_back_plate.stl | ✅ SUCCESS | [](https://ik.imagekit.io/vorondesign/ci_1023/_o__back_plate_LCEkOBEd.png) | | | [o]_insert_collar.stl | ✅ SUCCESS | [](https://ik.imagekit.io/vorondesign/ci_1023/_o__insert_collar_piEeaSaH.png) | | ---
WARNING: ⚠️ #### STL rotation checker | Item | Result | Original orientation | Suggested orientation | | --- | --- | --- | --- | | [oc]_insert.stl | ⚠️ WARNING | [](https://ik.imagekit.io/vorondesign/ci_1023/_oc__insert_VjATwdPM.png) | [](https://ik.imagekit.io/vorondesign/ci_1023/_oc__insert_rotated_PcRAvpcY.png) | | [a]_main_body.stl | ⚠️ WARNING | [](https://ik.imagekit.io/vorondesign/ci_1023/_a__main_body_uYAXNHGK.png) | [](https://ik.imagekit.io/vorondesign/ci_1023/_a__main_body_rotated_rxRLRogC.png) | ---
FAILURE: ❌
EXCEPTION: 💀

I am a 🤖, this comment was generated automatically!

Made with ❤️ by the VoronDesign GitHub Team

mjonuschat commented 7 months ago

STL Orientation looks ok based on README and the fact that the insert will have the text embossed which the automated check isn’t aware off.

MapleLeafMakers commented 7 months ago

STL Orientation looks ok based on README and the fact that the insert will have the text embossed which the automated check isn’t aware off.

Can Confirm:

[oc]_insert.stl is meant to have text engraved into the top surface, and then be flipped in the slicer to the orientation the bot suggested.

[a]_main_body.stl is oriented that way purely for aesthetics, it looks awful printed on its back.