Closed Dr-Info closed 7 months ago
Hi, unfortunately you have submitted this against the old "master" branch of the user mods repo. You will need to resubmit this against "main" as explained here:
https://github.com/VoronDesign/VoronUsers/wiki/VoronUsers-Overhaul
@chirpy2605 I have permissions to update the target branch. I'll take care of that for them.
hopefully that's all I screwed up...
There are some additional changes with the new system. I'll go through the PR and we'll get them sorted out...
I think it would be best to not make any further changes to this PR for now as something has gone a bit wrong with the last update. Ambulance has been called
OK, it looks like having the PR against the old master branch has caused some issues. To sort things out we're going to have to close this PR and ask you to submit a new one against the main branch. You will need to locally back up your mod files, delete the fork you have of the old system. Fork and work off of a branch from main as this will help prevent issues like this in the future.
What needs to be done is explained here: https://github.com/VoronDesign/VoronUsers/wiki/VoronUsers-Overhaul#id-like-to-resubmit
I made a few comments on this PR which you can go through as you work on the new PR to speed things along.
side question if I want to take over a mod specifically this one what is the recommendation? https://github.com/VoronDesign/VoronUsers/tree/main/orphaned_mods/edwardyeeks/V2.4_z_drive_motor_tensioner_mod
side question if I want to take over a mod specifically this one what is the recommendation? https://github.com/VoronDesign/VoronUsers/tree/main/orphaned_mods/edwardyeeks/V2.4_z_drive_motor_tensioner_mod
You can open an issue with regards to adopting orphaned mods using the template here > https://github.com/VoronDesign/VoronUsers/issues/new/choose
Closing this off now in anticipation of the resubmit as discussed with the user.
Which mods are added by this PR?
LRS_din_mount_offset, Lever_Connector_Side_Fan_Support and btt_5160T_plus_mounts
How was it tested?
Printed and installed on my VT
Any background context you want to provide?
Built a LDO VT 300 with BTT 5160T Plus using 2 LRS PSUs. Tight fit so I also added lever connector mount using available space on the side fan supports for the side skirt fans.
Screenshots (if appropriate)
⚠️⚠️PLEASE READ AND COMPLETE THE CHECKLIST BELOW⚠️⚠️