VoronDesign / VoronUsers

Voron Community mods
https://mods.vorondesign.com
GNU General Public License v3.0
2.95k stars 1.86k forks source link

feat: add switchwire cyd screen case files #1041

Closed Reemuson closed 4 months ago

Reemuson commented 4 months ago

Which mods are added by this PR?

How was it tested?

Tested on my Aquilawire SW.807

Screenshots

Switchwire_CYD_Screen_Case_Parts_Exploded

Any background context you want to provide?

Posted on Printables

⚠️⚠️PLEASE READ AND COMPLETE THE CHECKLIST BELOW⚠️⚠️

chirpy2605 commented 4 months ago

Look good to me

Reemuson commented 4 months ago

LGTM!

For future updates or other mods you can look into adding counterbore bridging to some of the countersunk holes in your models. Make it clean and easier to print+

Definitely an oversight on my side. Didn't cross my mind but am quite familiar with the process. Haven't designed something for FDM in a while so it wasn't on the brain. I'll get that sorted if you can wait before merge.

jontek2 commented 4 months ago

LGTM! For future updates or other mods you can look into adding counterbore bridging to some of the countersunk holes in your models. Make it clean and easier to print+

Definitely an oversight on my side. Didn't cross my mind but am quite familiar with the process. Haven't designed something for FDM in a while so it wasn't on the brain. I'll get that sorted if you can wait before merge.

Awesome! Thanks. Going to run the bot again just to be sure and once that's pass and Chirpy closes his review this should be ready for merge.

github-actions[bot] commented 4 months ago

Hi, thank you for submitting your PR. Please find below the results of the automated PR checker:

Added/Changed mods detected in this PR:

Item Result Description/Error Printer compatibility/Error Detail
Reemuson/SW_CYD_Screen_Case ✅ SUCCESS A VORON Switchwire mount-able case for the CYD screen. VSW

Tool check results overview:

Tool ⚠️ 💀
STL corruption checker 2
STL rotation checker 2
Mod structure checker
Readme generator 1
File checker 9

Tool check results details:

SUCCESS: ✅ #### STL corruption checker | Item | Result | Number of STL fixes applicable | | --- | --- | --- | | switchwire_cyd_case_front.stl | ✅ SUCCESS | 0 | | switchwire_cyd_case_back.stl | ✅ SUCCESS | 0 | --- #### STL rotation checker | Item | Result | Original orientation | Suggested orientation | | --- | --- | --- | --- | | switchwire_cyd_case_back.stl | ✅ SUCCESS | [](https://ik.imagekit.io/vorondesign/ci_1041/switchwire_cyd_case_back_WEgOhmsY.png) | | | switchwire_cyd_case_front.stl | ✅ SUCCESS | [](https://ik.imagekit.io/vorondesign/ci_1041/switchwire_cyd_case_front_VXkgoTtf.png) | | --- #### Readme generator | Item | Result | Description/Error | Printer compatibility/Error Detail | | --- | --- | --- | --- | | Reemuson/SW_CYD_Screen_Case | ✅ SUCCESS | A VORON Switchwire mount-able case for the CYD screen. | VSW | --- #### File checker | Item | Result | Reason | | --- | --- | --- | | Reemuson/SW_CYD_Screen_Case/.metadata.yml | ✅ SUCCESS | | | Reemuson/SW_CYD_Screen_Case/README.md | ✅ SUCCESS | | | Reemuson/SW_CYD_Screen_Case/STL/switchwire_cyd_case_front.stl | ✅ SUCCESS | | | Reemuson/SW_CYD_Screen_Case/STL/switchwire_cyd_case_back.stl | ✅ SUCCESS | | | Reemuson/SW_CYD_Screen_Case/Images/IMG_0503.JPEG | ✅ SUCCESS | | | Reemuson/SW_CYD_Screen_Case/Images/IMG_0502.JPEG | ✅ SUCCESS | | | Reemuson/SW_CYD_Screen_Case/Images/Switchwire_CYD_Screen_Case_Parts_Exploded.gif | ✅ SUCCESS | | | Reemuson/SW_CYD_Screen_Case/CAD/Switchwire_CYD_Screen_Case_Assembly.step | ✅ SUCCESS | | | Reemuson/SW_CYD_Screen_Case/OTHER/Switchwire_CYD_Screen_Case_Drawing_v4.pdf | ✅ SUCCESS | | ---

I am a 🤖, this comment was generated automatically!

Made with ❤️ by the VoronDesign GitHub Team