search

VoronDesign / VoronUsers

Voron Community mods
https://mods.vorondesign.com
GNU General Public License v3.0
2.95k stars 1.86k forks source link

Rs 50 5 bracket #1050

Closed Rikers-Beard closed 1 month ago

Rikers-Beard commented 1 month ago

Which mods are added by this PR?

 This PR adds a Meanwell RS-50-5 PSU DIN rail mount bracket.

How was it tested?

 I printed this bracket out, installed it on my RS-50-5 PSU, and finally installed the assembly onto the DIN rail in my V2.4r2

Any background context you want to provide?

 I initially tried the old RS-25-5 bracket and found it to be more wobbly on the DIN rail than I liked, this holds the bigger PSU nicely.

Screenshots (if appropriate)

mounted

⚠️⚠️PLEASE READ AND COMPLETE THE CHECKLIST BELOW⚠️⚠️

jontek2 commented 1 month ago

Hi @Rikers-Beard,

The CI-bot has detected an issues, could you please attend to that?

Also a few minor details i've noticed upon review:

Other than that it looks good to me!

Rikers-Beard commented 1 month ago

Hi, thanks for reviewing my submission. This is my first time submitting mods, sorry for any hiccups.

1.) I go by "Riker's Beard" on the voron discord and other related 3D printing channels. My discord username wasnt as "family friendly", I've changed it to be more relevant and will update my two submissions now.

2.) I only listed V2.4r2 compatibility because the guide states to "Please only specify printers that you have either tested your mod on yourself, or that someone else has tested for you". I have not found anyone else to test this mod for me yet, I will add "VT" and others with your approval.

Thanks for your help, feel free to revise printer compatibilities as you see fit from your end if possible.

On Tue, Jul 2, 2024, 9:45 AM Jonathan Hellman @.***> wrote:

Hi @Rikers-Beard https://github.com/Rikers-Beard,

The CI-bot has detected an issues, could you please attend to that?

Also a few minor details i've noticed upon review:

  • Your discord_username is probably wrong, seems like you put the screenname and not the username.
  • Any reason for not including the trident in "Printer Compability"?

Other than that it looks good to me!

— Reply to this email directly, view it on GitHub https://github.com/VoronDesign/VoronUsers/pull/1050#issuecomment-2203808276, or unsubscribe https://github.com/notifications/unsubscribe-auth/BJSSMKVR7VGYEGNJKPTGENDZKLKKZAVCNFSM6AAAAABKGYNDSSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDEMBTHAYDQMRXGY . You are receiving this because you were mentioned.Message ID: @.***>

Rikers-Beard commented 1 month ago

Okay username is corrected in the metadata.yml, added VT to list of compatibilities, this one should be good to go now. I also corrected the metadata in my other pending submission. Thanks.

Rikers-Beard commented 1 month ago

I'm confused as to why I am still getting errors on the checklist, I followed the sample_mod template and organized the file structure as directed. I'm standing by to make the necessary corrections.

jontek2 commented 1 month ago

Thanks for the updates. I think the error lies in description in the metadata-file, could you please try a shorter? Maybe something like "A Meanwell RS-50-5 PSU DIN rail mount bracket" or something? Longer text can be put in the README-file.

Rikers-Beard commented 1 month ago

Okay, that makes sense. I'll revise both mod submissions accordingly. Thank you.

Rikers-Beard commented 1 month ago

Both PRs revised.

github-actions[bot] commented 1 month ago

Hi, thank you for submitting your PR. Please find below the results of the automated PR checker:

Added/Changed mods detected in this PR:

Item Result Description/Error Printer compatibility/Error Detail
RikersBeard/RS-50-5_Bracket ✅ SUCCESS A Meanwell RS-50-5 PSU DIN rail mount bracket. V2.4r2, VT

Tool check results overview:

Tool ✅ ⚠️ ❌ 💀
STL corruption checker 1
File checker 6
Readme generator 1
Markdown link checker 2
Mod structure checker
STL rotation checker 1

Tool check results details:

SUCCESS: ✅ #### STL corruption checker | Item | Result | Number of STL fixes applicable | | --- | --- | --- | | RS-50-5_PSU_Bracket.stl | ✅ SUCCESS | 0 | --- #### File checker | Item | Result | Reason | | --- | --- | --- | | RikersBeard/RS-50-5_Bracket/README.md | ✅ SUCCESS | | | RikersBeard/RS-50-5_Bracket/.metadata.yml | ✅ SUCCESS | | | RikersBeard/RS-50-5_Bracket/STL/RS-50-5_PSU_Bracket.stl | ✅ SUCCESS | | | RikersBeard/RS-50-5_Bracket/Images/RS-50-5_PSU_Bracket.jpg | ✅ SUCCESS | | | RikersBeard/RS-50-5_Bracket/Images/mounted.jpg | ✅ SUCCESS | | | RikersBeard/RS-50-5_Bracket/CAD/RS-50-5_PSU_Bracket.step | ✅ SUCCESS | | --- #### Readme generator | Item | Result | Description/Error | Printer compatibility/Error Detail | | --- | --- | --- | --- | | RikersBeard/RS-50-5_Bracket | ✅ SUCCESS | A Meanwell RS-50-5 PSU DIN rail mount bracket. | V2.4r2, VT | --- #### Markdown link checker | Item | Result | Reason | | --- | --- | --- | | RikersBeard/RS-50-5_Bracket/README.md | ✅ SUCCESS | Relative link './Images/RS-50-5_PSU_Bracket.jpg' is valid! | | RikersBeard/RS-50-5_Bracket/README.md | ✅ SUCCESS | Relative link './Images/mounted.jpg' is valid! | --- #### STL rotation checker | Item | Result | Original orientation | Suggested orientation | | --- | --- | --- | --- | | RS-50-5_PSU_Bracket.stl | ✅ SUCCESS | [](https://ik.imagekit.io/vorondesign/ci_1050/RS-50-5_PSU_Bracket_qPZbztdW.png) | | ---

I am a 🤖, this comment was generated automatically!

Made with ❤️ by the VoronDesign GitHub Team