Closed Rikers-Beard closed 1 month ago
Hi @Rikers-Beard,
The CI-bot has detected an issues, could you please attend to that?
Also a few minor details i've noticed upon review:
Other than that it looks good to me!
Hi, thanks for reviewing my submission. This is my first time submitting mods, sorry for any hiccups.
1.) I go by "Riker's Beard" on the voron discord and other related 3D printing channels. My discord username wasnt as "family friendly", I've changed it to be more relevant and will update my two submissions now.
2.) I only listed V2.4r2 compatibility because the guide states to "Please only specify printers that you have either tested your mod on yourself, or that someone else has tested for you". I have not found anyone else to test this mod for me yet, I will add "VT" and others with your approval.
Thanks for your help, feel free to revise printer compatibilities as you see fit from your end if possible.
On Tue, Jul 2, 2024, 9:45 AM Jonathan Hellman @.***> wrote:
Hi @Rikers-Beard https://github.com/Rikers-Beard,
The CI-bot has detected an issues, could you please attend to that?
Also a few minor details i've noticed upon review:
- Your discord_username is probably wrong, seems like you put the screenname and not the username.
- Any reason for not including the trident in "Printer Compability"?
Other than that it looks good to me!
— Reply to this email directly, view it on GitHub https://github.com/VoronDesign/VoronUsers/pull/1050#issuecomment-2203808276, or unsubscribe https://github.com/notifications/unsubscribe-auth/BJSSMKVR7VGYEGNJKPTGENDZKLKKZAVCNFSM6AAAAABKGYNDSSVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDEMBTHAYDQMRXGY . You are receiving this because you were mentioned.Message ID: @.***>
Okay username is corrected in the metadata.yml, added VT to list of compatibilities, this one should be good to go now. I also corrected the metadata in my other pending submission. Thanks.
I'm confused as to why I am still getting errors on the checklist, I followed the sample_mod template and organized the file structure as directed. I'm standing by to make the necessary corrections.
Thanks for the updates. I think the error lies in description in the metadata-file, could you please try a shorter? Maybe something like "A Meanwell RS-50-5 PSU DIN rail mount bracket" or something? Longer text can be put in the README-file.
Okay, that makes sense. I'll revise both mod submissions accordingly. Thank you.
Both PRs revised.
Hi, thank you for submitting your PR. Please find below the results of the automated PR checker:
Item | Result | Description/Error | Printer compatibility/Error Detail |
---|---|---|---|
RikersBeard/RS-50-5_Bracket | ✅ SUCCESS | A Meanwell RS-50-5 PSU DIN rail mount bracket. | V2.4r2, VT |
Tool | ✅ | ⚠️ | ❌ | 💀 |
---|---|---|---|---|
STL corruption checker | 1 | |||
File checker | 6 | |||
Readme generator | 1 | |||
Markdown link checker | 2 | |||
Mod structure checker | ||||
STL rotation checker | 1 |
I am a 🤖, this comment was generated automatically!
Made with ❤️ by the VoronDesign GitHub Team
Which mods are added by this PR?
How was it tested?
Any background context you want to provide?
Screenshots (if appropriate)
⚠️⚠️PLEASE READ AND COMPLETE THE CHECKLIST BELOW⚠️⚠️