Closed Itzo1978 closed 1 month ago
jontek2
commented
1 month ago Hey @Itzo1978,
Looks like the bot has spotted issues with the metadata file. Seems like it contains unwanted characters.
I also noted that you uploaded 3mf files, but in the metadata refer to them as stl's. Could you change them to stls?
Itzo1978
commented
1 month ago Hey, I hadn't paid attention to the extension used. It's been corrected
Thank you for reporting
Le dim. 22 sept. 2024 à 13:04, Jonathan Hellman @.***> a écrit :
Hey @Itzo1978 https://github.com/Itzo1978,
Looks like the bot has spotted issues with the metadata file. Seems like it contains unwanted characters.
I also noted that you uploaded 3mf files, but in the metadata refer to them as stl's. Could you change them to stls?
— Reply to this email directly, view it on GitHub https://github.com/VoronDesign/VoronUsers/pull/1054#issuecomment-2366727838, or unsubscribe https://github.com/notifications/unsubscribe-auth/AXY4VM3M3EKLT2UIYSFDU73ZX2P3HAVCNFSM6AAAAABOULZGVGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGNRWG4ZDOOBTHA . You are receiving this because you were mentioned.Message ID: @.***>
jontek2
commented
1 month ago @Itzo1978 As i was typing i saw that you pushed some changes, hehe.
Seems like there's still a typo with "cad :" where it should be "cad:". I'll run the bot and see if there's any other changes needed aswell.
Itzo1978
commented
1 month ago Maybe a anothers problems : a space between Top and Idlers ? I don't know how to change... I'm discovering these features 🙈
Le dim. 22 sept. 2024 à 17:15, Jonathan Hellman @.***> a écrit :
@Itzo1978 https://github.com/Itzo1978 As i was typing i saw that you pushed some changes, hehe.
Seems like there's still a typo with "cad :" wherte it should be "cad:". I'll run the bot and see if there's any other changes needed aswell.
— Reply to this email directly, view it on GitHub https://github.com/VoronDesign/VoronUsers/pull/1054#issuecomment-2366832121, or unsubscribe https://github.com/notifications/unsubscribe-auth/AXY4VM2EQICDXMO34BM22H3ZX3NKDAVCNFSM6AAAAABOULZGVGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGNRWHAZTEMJSGE . You are receiving this because you were mentioned.Message ID: @.***>
jontek2
commented
1 month ago No worries, we'll figure it out.
I belive you have some naming issues with your files vs the yml file. If you look at the yml file it says:
cad:
Where the actual filenames are:
CAD/[a]_ztop_tensioner_9mm_x4.step CAD/ztop_tensioner_bracket_a_x2.step CAD/ztop_tensioner_bracket_b_x2.step
Please update this and i'll run the bot again.
Itzo1978
commented
1 month ago and now ?
Le dim. 22 sept. 2024 à 17:27, Jonathan Hellman @.***> a écrit :
No worries, we'll figure it out.
I belive you have some naming issues with your files vs the yml file. If you look at the yml file it says:
`cad:
- CAD/[a]_z-top_tensioner_9mm_x4.step
- CAD/z-top_tensioner_bracket_a_x2.step
- CAD/z-top_tensioner_bracket_b_x2.step`
Where the actual filenames are:
CAD/[a]_ztop_tensioner_9mm_x4.step CAD/ztop_tensioner_bracket_a_x2.step CAD/ztop_tensioner_bracket_b_x2.step
Please update this and i'll run the bot again.
— Reply to this email directly, view it on GitHub https://github.com/VoronDesign/VoronUsers/pull/1054#issuecomment-2366838440, or unsubscribe https://github.com/notifications/unsubscribe-auth/AXY4VMZTKEV7KFRQGXX3P5TZX3OWNAVCNFSM6AAAAABOULZGVGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDGNRWHAZTQNBUGA . You are receiving this because you were mentioned.Message ID: @.***>
github-actions[bot]
commented
1 month ago Hi, thank you for submitting your PR. Please find below the results of the automated PR checker:
| Item | Result | Description/Error | Printer compatibility/Error Detail |
|---|---|---|---|
| Itzo1978/Z-Top_Idlers | ✅ SUCCESS | Z-axis tensioner tightened from above, with the screw aligned with... | V2.4r2 |
| Tool | ✅ | ⚠️ | ❌ | 💀 |
|---|---|---|---|---|
| File checker | 12 | |||
| Readme generator | 1 | |||
| STL corruption checker | 3 | |||
| STL rotation checker | 3 | |||
| Mod structure checker |
](https://ik.imagekit.io/vorondesign/ci_1054/_a__ztop_tensioner_9mm_x4_OOgDovwL.png) | |
| ztop_tensioner_bracket_a_x2.stl | ✅ SUCCESS | [
](https://ik.imagekit.io/vorondesign/ci_1054/ztop_tensioner_bracket_a_x2_eOiQTFdW.png) | |
| ztop_tensioner_bracket_b_x2.stl | ✅ SUCCESS | [
](https://ik.imagekit.io/vorondesign/ci_1054/ztop_tensioner_bracket_b_x2_TFLjqfoC.png) | |
---
I am a 🤖, this comment was generated automatically!
Made with ❤️ by the VoronDesign GitHub Team
jontek2
commented
1 month ago Hey @Itzo1978 ,
After internal discussion and review, we've decided to reject this mod submission as it does not meet our submission rules, specifically the "Mods must not represent slight modifications of existing mods/existing VoronDesign printer parts."
However, you're more than welcome to upload it to platforms like Printables or other 3D model databases.
If you have any questions, feel free to reach out to us on Discord.
What mods has this PR added?
Replacing the original Z Idlers with my model
How has it been tested?
It was tested on my machine, the Voron 2.4 (v2.3941)
Any context you wish to provide?
I noticed a deformation of the belts. It's moving forwards causing the belt to be a few millimetres out of alignment. Consequence: the Z height cannot be respected without a correction in klipper (with
distance_rotation)My model makes it possible to correct this phenomenon
Tightening the screw from above to tighten the belt is much easier than from below.
Screenshots (if appropriate)
in progress
⚠️⚠️PLEASE READ AND COMPLETE THE CHECKLIST BELOW⚠️⚠️