VoronDesign / VoronUsers

Voron Community mods
https://mods.vorondesign.com
GNU General Public License v3.0
3k stars 1.86k forks source link

Added new user and mod for a door activated light switch #1056

Open Sjack1209 opened 3 weeks ago

Sjack1209 commented 3 weeks ago

Which mods are added by this PR?

Voron_Fridge_Door_Light_Switch

How was it tested?

I have it in use on my printer with no issues. I took it through several iterations before uploading it.

Any background context you want to provide?

I wanted a way to make my white LED's go to full brightness when the door is opened since I usually keep them around 10% in the software. This mod allows you to install a microswitch that accomplishes that.

Screenshots (if appropriate)

⚠️⚠️PLEASE READ AND COMPLETE THE CHECKLIST BELOW⚠️⚠️

jontek2 commented 3 weeks ago

Thanks for submitting your mod. Please check the results from the bot above and correct the issues it has mentioned.

I also noticed that the README contains "(Link to Amazon)" and "(Link to Aliexpress)" without any actual links. It's probably best to remove these as well.

Sjack1209 commented 2 weeks ago

This is going to fail again. I think I figured out why it wasn't working....Is it case sensitive when writing file paths? If so, I've corrected it and will re-submit again once the prior request is completed.

github-actions[bot] commented 1 week ago

Hi, thank you for submitting your PR. Please find below the results of the automated PR checker:

Added/Changed mods detected in this PR:

Item Result Description/Error Printer compatibility/Error Detail
Sjack1209/Fridge_Door_Light_Switch ✅ SUCCESS This mod allows you to maintain software control of your white LED... V2.4r2, VT

Tool check results overview:

Tool ⚠️ 💀
Mod structure checker 8
File checker 12
STL corruption checker 1
Readme generator 1
Markdown link checker 5
STL rotation checker 1

Tool check results details:

SUCCESS: ✅ #### File checker | Item | Result | Reason | | --- | --- | --- | | Sjack1209/Fridge_Door_Light_Switch/.metadata.yml | ✅ SUCCESS | | | Sjack1209/Fridge_Door_Light_Switch/README.md | ✅ SUCCESS | | | Sjack1209/Fridge_Door_Light_Switch/STL/Voron_Fridge_Door_Light_Switch.stl | ✅ SUCCESS | | | Sjack1209/Fridge_Door_Light_Switch/Images/Bending_tip_to_touch_door.jpg | ✅ SUCCESS | | | Sjack1209/Fridge_Door_Light_Switch/Images/Bent_Terminals.jpg | ✅ SUCCESS | | | Sjack1209/Fridge_Door_Light_Switch/Images/CAD.png | ✅ SUCCESS | | | Sjack1209/Fridge_Door_Light_Switch/Images/CAD_Wiring_Diagram.png | ✅ SUCCESS | | | Sjack1209/Fridge_Door_Light_Switch/Images/Fully_Installed.jpg | ✅ SUCCESS | | | Sjack1209/Fridge_Door_Light_Switch/Images/Fridge_Door_Light_Switch_Demo.gif | ✅ SUCCESS | | | Sjack1209/Fridge_Door_Light_Switch/Images/Switch_Mods.jpg | ✅ SUCCESS | | | Sjack1209/Fridge_Door_Light_Switch/CAD/Voron_Fridge_Door_Light_Switch.f3d | ✅ SUCCESS | | | Sjack1209/Fridge_Door_Light_Switch/CAD/Voron_Fridge_Door_Light_Switch.step | ✅ SUCCESS | | --- #### STL corruption checker | Item | Result | Number of STL fixes applicable | | --- | --- | --- | | Voron_Fridge_Door_Light_Switch.stl | ✅ SUCCESS | 0 | --- #### Readme generator | Item | Result | Description/Error | Printer compatibility/Error Detail | | --- | --- | --- | --- | | Sjack1209/Fridge_Door_Light_Switch | ✅ SUCCESS | This mod allows you to maintain software control of your white LED... | V2.4r2, VT | --- #### Markdown link checker | Item | Result | Reason | | --- | --- | --- | | Sjack1209/Fridge_Door_Light_Switch/README.md | ✅ SUCCESS | Relative link './Images/CAD.png' is valid! | | Sjack1209/Fridge_Door_Light_Switch/README.md | ✅ SUCCESS | Relative link './Images/Bent_Terminals.jpg' is valid! | | Sjack1209/Fridge_Door_Light_Switch/README.md | ✅ SUCCESS | Relative link './Images/Bending_tip_to_touch_door.jpg' is valid! | | Sjack1209/Fridge_Door_Light_Switch/README.md | ✅ SUCCESS | Relative link './Images/Switch_Mods.jpg' is valid! | | Sjack1209/Fridge_Door_Light_Switch/README.md | ✅ SUCCESS | Relative link './Images/Fully_Installed.jpg' is valid! | --- #### STL rotation checker | Item | Result | Original orientation | Suggested orientation | | --- | --- | --- | --- | | Voron_Fridge_Door_Light_Switch.stl | ✅ SUCCESS | [](https://ik.imagekit.io/vorondesign/ci_1056/Voron_Fridge_Door_Light_Switch_vrYaJJWU.png) | | ---
FAILURE: ❌ #### Mod structure checker | Item | Result | Reason | | --- | --- | --- | | Sjack1209/Fridge_Door_Light_Switch/images/Fridge_Door_Light Switch_Demo.gif | ❌ FAILURE | The file is listed in the metadata.yml file but does not exist | | Sjack1209/Fridge_Door_Light_Switch/images/CAD.png | ❌ FAILURE | The file is listed in the metadata.yml file but does not exist | | Sjack1209/Fridge_Door_Light_Switch/images/CAD_Wiring_Diagram.png | ❌ FAILURE | The file is listed in the metadata.yml file but does not exist | | Sjack1209/Fridge_Door_Light_Switch/images/Switch_Mods.jpg | ❌ FAILURE | The file is listed in the metadata.yml file but does not exist | | Sjack1209/Fridge_Door_Light_Switch/images/Bending_tip_to_touch_door.jpg | ❌ FAILURE | The file is listed in the metadata.yml file but does not exist | | Sjack1209/Fridge_Door_Light_Switch/images/Bent_Terminals.jpg | ❌ FAILURE | The file is listed in the metadata.yml file but does not exist | | Sjack1209/Fridge_Door_Light_Switch/images/Fully_Installed.jpg | ❌ FAILURE | The file is listed in the metadata.yml file but does not exist | | Sjack1209/Fridge_Door_Light_Switch/STLs/Voron_Fridge_Door_Light_Switch.stl | ❌ FAILURE | The file is listed in the metadata.yml file but does not exist | ---

I am a 🤖, this comment was generated automatically!

Made with ❤️ by the VoronDesign GitHub Team

jontek2 commented 1 week ago

It appears there are inconsistencies between the naming of the image folder and files in the YAML file and the actual image folder. Please update and i'll run the CI again.