search

Vortec4800 / homebridge-ecobee-away

Homebridge plugin to access or set the Ecobee's home and away status
Apache License 2.0
6 stars 6 forks source link

Support for multiple thermostats #8

Closed longlostnick closed 2 years ago

longlostnick commented 2 years ago

Adds support for multiple thermostats!

It’s really interesting that this didn’t just work out of the box given their documentation for the registered selection type says:

When this is set the thermostats registered to the current user will be returned.

I also did some testing and if there are no ids the selectionType needs to go back to registered otherwise it fails. Hence the conditional.

Vortec4800 commented 2 years ago

Looks good, thanks for the PR. Can you update the sample config.json in the Readme to include the field for multiple thermostats? Then I think we're good to merge.

longlostnick commented 2 years ago

Alright, updated. I also renamed thermostatIds to thermostatSerialNumbers because my original naming was bothering me 😆

Vortec4800 commented 2 years ago

Looks good. Thanks!