search

Vortyne / pureRGB

Pokemon PureRed / PureBlue / PureGreen: A purist's enhancement of Pokemon Red/Blue/Green based on the pokered decompilation.
243 stars 27 forks source link

[2.4.4] Seismic Toss displays type effectiveness. #41

Closed BritishCynic closed 1 year ago

BritishCynic commented 1 year ago

As Seismic Toss should ignore type effectiveness, this move should completely ignore type effectiveness and just deal its intended damage, but the move displays type effectiveness messages.

Vortyne commented 1 year ago

Due to changing it to fighting type, it displays type effectiveness in some cases - in the original game due to being normal type it just showed normal type effectiveness

BritishCynic commented 1 year ago

... Seismic Toss was always a fighting-type move in Generation I.

Vortyne commented 1 year ago

Whoops, that means I made a mistake and created that bug

Vortyne commented 1 year ago

Seems the bug may have been created when I modified tri attack. I must have removed SPECIAL_DAMAGE_EFFECT from the SetDamageEffects array and should have kept it in there due to sonic boom and seismic toss.

Vortyne commented 1 year ago

Should be fixed in the next version