search

Voting-Rights-Code / Equitable-Polling-Locations

Optimization tool for selecting the most equiatable set of polling locations (by Kolm-Pollack distance)
GNU General Public License v3.0
9 stars 3 forks source link

17 driving distances table version #34

Closed dskipper closed 6 months ago

dskipper commented 6 months ago

This should be complete now.

Amasus commented 6 months ago

Agreed. The code looks beautiful and ready to merge. My fear is that, given the number of files that are different from what is in main, and that they are mostly .csvs, if we merge into main, we are going to clobber correct files with new ones that we don't know the provenance of. Not sure wat to do about it. Thinking.... Happy to hear ideas.

Amasus commented 6 months ago

Apologies, I know I said that this was good, but on further reflection, I'm realizing that the insert_driving_distance function coud probably use a test. To do this, you will add a function in tests/model_run_test.py.

To do this, you will likely need to create a fake driving distances file, possibly by modifying the functions in make_test_data.py

When you are doine, you should just be able to type pytest, and it will tell you if things worked or not.

dskipper commented 6 months ago

Files to update: model_config.py model_run.py model_data.py README.md tests/model_run_test.py tests/testing_config_driving.yaml

Directories to update: Engage_VA_driving_2024_configs Gwinnett_GA_driving_no_bg_no_ed_configs datasets/driving

Amasus commented 6 months ago

This looks perfect. I've merged in main, and cleaned up some of ther Engage_VA config folders. I think it is ready to merge this into main now if you are