search

Voting-Rights-Code / Equitable-Polling-Locations

Optimization tool for selecting the most equiatable set of polling locations (by Kolm-Pollack distance)
GNU General Public License v3.0
9 stars 3 forks source link

Feature/penalty updated #38

Closed dskipper closed 6 months ago

dskipper commented 7 months ago

Moved penalty code to subroutine. Implemented logging consistent with existing code. Updated readme. Added a test.

Amasus commented 7 months ago

I still have some questions on this one. Can we talk through this on Sunday. I also wanted to suggest a refactor of some of the work you've done. I'll make an PR for that shortly

Amasus commented 6 months ago

I owe you an apology. What you had done was absolutely fine. I didn't need to stick my fingers into it further. I'm sorry. I've closed out that other pull request.

I've mover the incorporate_penaties and get_log_path into model_pentalties.py, and left all the code itself the same. Lets talk about this on Sunday and finish this up.

dskipper commented 6 months ago

Cool :)

I didn't really mind about the changes, I just didn't want to do it, lol. ;)

Daphne Skipper, Ph.D. Associate Professor Mathematics Department United States Naval Academy pronouns: she/her

https://www.usna.edu/Users/math/skipper/ https://www.usna.edu/Users/math/skipper/

On Sat, May 11, 2024 at 9:55 AM Amasus @.***> wrote:

I owe you an apology. What you had done was absolutely fine. I didn't need to stick my fingers into it further. I'm sorry. I've closed out that other pull request.

I've mover the incorporate_penaties and get_log_path into model_pentalties.py, and left all the code itself the same. Lets talk about this on Sunday and finish this up.

— Reply to this email directly, view it on GitHub https://github.com/Voting-Rights-Code/Equitable-Polling-Locations/pull/38#issuecomment-2105790615, or unsubscribe https://github.com/notifications/unsubscribe-auth/AJFZU2ZZBEMWYCEMD46NRBLZBYPLPAVCNFSM6AAAAABHB36UG2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCMBVG44TANRRGU . You are receiving this because you authored the thread.Message ID: @.*** .com>