search

VowpalWabbit / coba

Contextual bandit benchmarking
https://coba-docs.readthedocs.io/
BSD 3-Clause "New" or "Revised" License
48 stars 19 forks source link

Add CI #10

Closed lalo closed 2 years ago

jackgerrits commented 2 years ago

Since Coba is pure python manylinux should not be needed

mrucker commented 2 years ago

Hey also, I'm really ignorant about this kind of stuff with Python. Where is the service that would process this file? I've always assumed there's some online service we could setup to watch the repo and re-run the tests every time there is a commit. Is that what this is? In my mind I was thinking something like codecove (I know VW, matplotlib, and pandas use it) and Azure pipeline (also used by VW, matplotlib, and pandas).

jackgerrits commented 2 years ago

Github has their own automated testing service now which is free for open source projects (called Github Actions). It is well integrated wit Github of course and is (in my opinion) probably the best experience at the moment.

It looks like so far Eduardo is just experimenting. But eventually this could run tests, run linters and do type checking. This fun would run against each commit and PR. Having these automatic checks in place really helps you be confident the code is in a good state.

lalo commented 2 years ago

@mrucker hey Mark, can you merge this as-is? That should enable CI once its on the main branch. If not we can revert back or fix. Thanks.

edit: actually I'll just merge, its trivial change.

mrucker commented 2 years ago

@lalo That's awesome. Yeah if any of my recent commits are conflicting I'm happy to do the merge. Just let me know. I've been working to get ready for the CI stuff over the holiday break by increasing test coverage. I'm doing one file a night, so we should have complete test coverage in about three more weeks. We're currently at about 87% coverage.