fix: stash and restore prediction when calling learn during learn_returns_prediction==false calls

VowpalWabbit / vowpal_wabbit

Vowpal Wabbit is a machine learning system which pushes the frontier of machine learning with techniques such as online, hashing, allreduce, reductions, learning2search, active, and interactive learning.

https://vowpalwabbit.org

Other

8.49k stars 1.93k forks source link

fix: stash and restore prediction when calling learn during learn_returns_prediction==false calls #4632

Closed jackgerrits closed 1 year ago

jackgerrits commented 1 year ago

Fixes Igl's usage of the prediction in learn
Causes one less call to predict for cats which means the PRNG sequence changes and so do the predictions.
Seems that expreplay used to be returning the final prediction that was coming out of GD in its learn call. This fixes that to be the initial predict.