VowpalWabbit / vowpal_wabbit

Vowpal Wabbit is a machine learning system which pushes the frontier of machine learning with techniques such as online, hashing, allreduce, reductions, learning2search, active, and interactive learning.
https://vowpalwabbit.org
Other
8.49k stars 1.93k forks source link

fix: Update VcPkg to fix issue when installing Zlib #4677

Closed lokitoth closed 10 months ago

lokitoth commented 10 months ago

The current VcPkg version's port of zlib relies on a msys2 dependency to be downloaded from the web (in this case libwinpthreads), which now errors out with 404. This has not been caught by CI because we cache vcpkg artifacts to avoid a very long build-time. The fix is to upgrade vcpkg to a newer version.

Changes:

In addition: We should consider adding a vcpkg-only test action on a schedule (or similar) to ensure that we catch these

lokitoth commented 10 months ago

Force-push to fix semantic-title check

lokitoth commented 10 months ago

Closing, since this is a duplicate (ish, later vcpkg version) of #4672