VowpalWabbit / vowpal_wabbit

Vowpal Wabbit is a machine learning system which pushes the frontier of machine learning with techniques such as online, hashing, allreduce, reductions, learning2search, active, and interactive learning.
https://vowpalwabbit.org
Other
8.49k stars 1.93k forks source link

build: Fix building against RapidJSON 1.1.0 as sys dep #4682

Closed geofft closed 9 months ago

geofft commented 10 months ago

The last release of RapidJSON, 1.1.0 from 2016 (see Tencent/rapidjson#1006 I guess), spells the variable in all caps: https://github.com/Tencent/rapidjson/blob/v1.1.0/RapidJSONConfig.cmake.in Use both spellings to accommodate both people on the last release and people who have picked a newer git commit.

lokitoth commented 9 months ago

Thanks for the fix @geofft!