search

VoxelBoy / MobileUO

MobileUO - the first mobile client for Ultima Online!
182 stars 48 forks source link

[CS] SoundsLoader: Fix missing music issue #23

Closed hubertwang closed 1 month ago

hubertwang commented 2 months ago

Hi @VoxelBoy,

I slightly modified patch from ClassicUO repo (issue). ClassicUO used a new path utility that's not exist in this repo, so I used UOFileManager.GetUOFilePath to find path to Music folder.

Please help to review this PR, thanks.

hubertwang commented 2 months ago

Latest SoundsLoader.cs code can be found here

VoxelBoy commented 2 months ago

Hi @hubertwang, did you test this in the Unity Editor or a build that this fixes the issue and music plays in-game?

hubertwang commented 2 months ago

Hi @hubertwang, did you test this in the Unity Editor or a build that this fixes the issue and music plays in-game?

Yes, I tested it with my iPhone, but I dont have a android device, havent tried it in android yet.

Should we release it to tesflight?l or android beta? More ppl join the test can increase the confidence level.