search

VoxelCubes / PanelCleaner

An AI-powered tool to clean manga panels.
GNU General Public License v3.0
215 stars 16 forks source link

Dockerfile missing dbus dependencies #101

Closed Trinovantes closed 2 months ago

Trinovantes commented 3 months ago

Describe the bug

I couldn't build the docker image in WSL without adding these 2 additional dependencies:

diff --git a/Dockerfile b/Dockerfile
index 2f2cc01..1145471 100644
--- a/Dockerfile
+++ b/Dockerfile
@@ -16,6 +16,8 @@ ENV PATH "${HOME}/.local/bin/:${PATH}"
 RUN apt-get update && apt-get install -y --no-install-recommends \
         libgl1 \
         libglib2.0-0 \
+        libdbus-1-dev \
+        dbus \
         vim \
         nano

To Reproduce Steps to reproduce the behavior:

  1. Clone repo
  2. docker buildx build -t pcleaner:v1 .

Expected behavior No errors

Session Log

Executing subproject dbus-gmain
13.48
13.48       dbus-gmain| Project name: dbus-gmain
13.48       dbus-gmain| Project version: undefined
13.48       dbus-gmain| C compiler for the host machine: cc (gcc 8.3.0 "cc (Debian 8.3.0-6) 8.3.0")
13.48       dbus-gmain| C linker for the host machine: cc ld.bfd 2.31.1
13.48       dbus-gmain| Compiler for C supports arguments -fno-common: YES (cached)
13.48       dbus-gmain| Compiler for C supports arguments -Wno-missing-field-initializers: YES (cached)
13.48       dbus-gmain| Compiler for C supports arguments -Wcast-align: YES (cached)
13.48       dbus-gmain| Compiler for C supports arguments -Wdouble-promotion: YES (cached)
13.48       dbus-gmain| Compiler for C supports arguments -Wduplicated-branches: YES
13.48       dbus-gmain| Compiler for C supports arguments -Wduplicated-cond: YES (cached)
13.48       dbus-gmain| Compiler for C supports arguments -Wfloat-equal: YES (cached)
13.48       dbus-gmain| Compiler for C supports arguments -Wformat-nonliteral: YES (cached)
13.48       dbus-gmain| Compiler for C supports arguments -Wformat-security: YES (cached)
13.48       dbus-gmain| Compiler for C supports arguments -Wformat=2: YES (cached)
13.48       dbus-gmain| Compiler for C supports arguments -Winit-self: YES (cached)
13.48       dbus-gmain| Compiler for C supports arguments -Wlogical-op: YES (cached)
13.48       dbus-gmain| Compiler for C supports arguments -Wmissing-declarations: YES (cached)
13.48       dbus-gmain| Compiler for C supports arguments -Wmissing-format-attribute: YES (cached)
13.48       dbus-gmain| Compiler for C supports arguments -Wmissing-include-dirs: YES (cached)
13.48       dbus-gmain| Compiler for C supports arguments -Wmissing-noreturn: YES (cached)
13.48       dbus-gmain| Compiler for C supports arguments -Wnull-dereference: YES (cached)
13.48       dbus-gmain| Compiler for C supports arguments -Wpacked: YES (cached)
13.48       dbus-gmain| Compiler for C supports arguments -Wpointer-arith: YES (cached)
13.48       dbus-gmain| Compiler for C supports arguments -Wredundant-decls: YES
13.48       dbus-gmain| Compiler for C supports arguments -Wshadow: YES (cached)
13.48       dbus-gmain| Compiler for C supports arguments -Wswitch-default: YES
13.48       dbus-gmain| Compiler for C supports arguments -Wswitch-enum: YES (cached)
13.48       dbus-gmain| Compiler for C supports arguments -Wundef: YES (cached)
13.48       dbus-gmain| Compiler for C supports arguments -Wunused-but-set-variable: YES (cached)
13.48       dbus-gmain| Compiler for C supports arguments -Wwrite-strings: YES
13.48       dbus-gmain| Compiler for C supports arguments -Wdeclaration-after-statement: YES
13.48       dbus-gmain| Compiler for C supports arguments -Wjump-misses-init: YES (cached)
13.48       dbus-gmain| Compiler for C supports arguments -Wmissing-prototypes: YES (cached)
13.48       dbus-gmain| Compiler for C supports arguments -Wnested-externs: YES (cached)
13.48       dbus-gmain| Compiler for C supports arguments -Wold-style-definition: YES (cached)
13.48       dbus-gmain| Compiler for C supports arguments -Wpointer-sign: YES (cached)
13.48       dbus-gmain| Compiler for C supports arguments -Wstrict-prototypes: YES (cached)
13.48       dbus-gmain| Found pkg-config: YES (/usr/bin/pkg-config) 0.29
13.48       dbus-gmain| Did not find CMake 'cmake'
13.48       dbus-gmain| Found CMake: NO
13.48       dbus-gmain| Run-time dependency dbus-1 found: NO (tried pkgconfig)
13.48
13.48       ../subprojects/dbus-gmain/meson.build:107:11: ERROR: Dependency "dbus-1" not found, tried pkgconfig

With libdbus-1-dev but without dbus:

Executing subproject dbus-gmain
56.25
56.25       dbus-gmain| Project name: dbus-gmain
56.25       dbus-gmain| Project version: undefined
56.25       dbus-gmain| C compiler for the host machine: cc (gcc 8.3.0 "cc (Debian 8.3.0-6) 8.3.0")
56.25       dbus-gmain| C linker for the host machine: cc ld.bfd 2.31.1
56.25       dbus-gmain| Compiler for C supports arguments -fno-common: YES (cached)
56.25       dbus-gmain| Compiler for C supports arguments -Wno-missing-field-initializers: YES (cached)
56.25       dbus-gmain| Compiler for C supports arguments -Wcast-align: YES (cached)
56.25       dbus-gmain| Compiler for C supports arguments -Wdouble-promotion: YES (cached)
56.25       dbus-gmain| Compiler for C supports arguments -Wduplicated-branches: YES
56.25       dbus-gmain| Compiler for C supports arguments -Wduplicated-cond: YES (cached)
56.25       dbus-gmain| Compiler for C supports arguments -Wfloat-equal: YES (cached)
56.25       dbus-gmain| Compiler for C supports arguments -Wformat-nonliteral: YES (cached)
56.25       dbus-gmain| Compiler for C supports arguments -Wformat-security: YES (cached)
56.25       dbus-gmain| Compiler for C supports arguments -Wformat=2: YES (cached)
56.25       dbus-gmain| Compiler for C supports arguments -Winit-self: YES (cached)
56.25       dbus-gmain| Compiler for C supports arguments -Wlogical-op: YES (cached)
56.25       dbus-gmain| Compiler for C supports arguments -Wmissing-declarations: YES (cached)
56.25       dbus-gmain| Compiler for C supports arguments -Wmissing-format-attribute: YES (cached)
56.25       dbus-gmain| Compiler for C supports arguments -Wmissing-include-dirs: YES (cached)
56.25       dbus-gmain| Compiler for C supports arguments -Wmissing-noreturn: YES (cached)
56.25       dbus-gmain| Compiler for C supports arguments -Wnull-dereference: YES (cached)
56.25       dbus-gmain| Compiler for C supports arguments -Wpacked: YES (cached)
56.25       dbus-gmain| Compiler for C supports arguments -Wpointer-arith: YES (cached)
56.25       dbus-gmain| Compiler for C supports arguments -Wredundant-decls: YES
56.25       dbus-gmain| Compiler for C supports arguments -Wshadow: YES (cached)
56.25       dbus-gmain| Compiler for C supports arguments -Wswitch-default: YES
56.25       dbus-gmain| Compiler for C supports arguments -Wswitch-enum: YES (cached)
56.25       dbus-gmain| Compiler for C supports arguments -Wundef: YES (cached)
56.25       dbus-gmain| Compiler for C supports arguments -Wunused-but-set-variable: YES (cached)
56.25       dbus-gmain| Compiler for C supports arguments -Wwrite-strings: YES
56.25       dbus-gmain| Compiler for C supports arguments -Wdeclaration-after-statement: YES
56.25       dbus-gmain| Compiler for C supports arguments -Wjump-misses-init: YES (cached)
56.25       dbus-gmain| Compiler for C supports arguments -Wmissing-prototypes: YES (cached)
56.25       dbus-gmain| Compiler for C supports arguments -Wnested-externs: YES (cached)
56.25       dbus-gmain| Compiler for C supports arguments -Wold-style-definition: YES (cached)
56.25       dbus-gmain| Compiler for C supports arguments -Wpointer-sign: YES (cached)
56.25       dbus-gmain| Compiler for C supports arguments -Wstrict-prototypes: YES (cached)
56.25       dbus-gmain| Found pkg-config: YES (/usr/bin/pkg-config) 0.29
56.25       dbus-gmain| Run-time dependency dbus-1 found: YES 1.12.28
56.25       dbus-gmain| Run-time dependency glib-2.0 found: YES 2.58.3
56.25       dbus-gmain| Run-time dependency gthread-2.0 found: YES 2.58.3
56.25       dbus-gmain| Program dbus-run-session found: NO
56.25       dbus-gmain| Build targets in project: 1
56.25       dbus-gmain| Subproject dbus-gmain finished.
56.25
56.25       Program python found: YES (/usr/local/bin/python)
56.25       Dependency dbus-1 found: YES 1.12.28 (cached)
56.25       Run-time dependency python found: YES 3.10
56.25       Configuring TestSuitePythonService.service using configuration
56.25       Configuring tmp-session-bus.conf using configuration
56.25       Program dbus-run-session found: NO
56.25
56.25       ../test/meson.build:72:19: ERROR: Program 'dbus-run-session' not found or not executable

Additional context This was done inside WSL2 on Windows 11

VoxelCubes commented 3 months ago

Hm, do you happen to know if this is exclusively a problem with WSL? Otherwise I will test it in a few days when I have the time to investigate.
Thanks for the heads up!

Trinovantes commented 3 months ago

It also happens on my ubuntu 22.04 server

VoxelCubes commented 2 months ago

Thanks!