Error while downloading models

masiv1001 commented 9 months ago

I'm using Fedora 39, using the binaries provided (I could not get it working using pip nor docker, they gave dependency errors). Everything works until I click OK and proceed with model downloading.

Logs after launching:

[salt@salt PanelCleaner]$ ./PanelCleaner 
torchvision/io/image.py:13: UserWarning: Failed to load image Python extension: ''If you don't plan on using image functionality from `torchvision.io`, you can ignore this warning. Otherwise, there might be something wrong with your environment. Did you have `libjpeg` or `libpng` installed before building `torchvision` from source?
torch/_jit_internal.py:857: UserWarning: Unable to retrieve source for @torch.jit._overload function: <function _DenseLayer.forward at 0x7f740c992700>.
  warnings.warn(
torch/_jit_internal.py:857: UserWarning: Unable to retrieve source for @torch.jit._overload function: <function _DenseLayer.forward at 0x7f740c993740>.
  warnings.warn(
[I 231129 13:25:39 launcher:32] 
    ---- Starting up ----
[I 231129 13:25:39 launcher:51] 
    - Program Information -
    Program: Panel Cleaner 2.1.0
    Log file is /home/salt/.cache/pcleaner/pcleaner.log
    Config file is /home/salt/.config/pcleaner/pcleanerrc
    Cache directory is /home/salt/.cache/pcleaner
    - System Information -
    Operating System: Linux 6.5.11-300.fc39.x86_64
    Machine: x86_64
    Python Version: 3.11.5 (main, Sep  2 2023, 14:16:33) [GCC 13.2.1 20230801]
    PySide (Qt) Version: 6.5.3
    Available Qt Themes: Windows, Fusion
    CPU Cores: 8
    GPU: None (CUDA not available)

Gtk-Message: 13:25:39.641: Failed to load module "canberra-gtk-module"
Gtk-Message: 13:25:39.641: Failed to load module "pk-gtk-module"
[E 231129 13:25:44 model_downloader_driver:181] HTTPSConnectionPool(host='github.com', port=443): Max retries exceeded with url: /zyddnys/manga-image-translator/releases/download/beta-0.3/comictextdetector.pt.onnx (Caused by SSLError(SSLError(0, 'unknown error (_ssl.c:3098)')))
    NoneType: None
[E 231129 13:25:44 model_downloader_driver:117] Failed to download all models.
[C 231129 13:25:44 mainwindow_driver:310] Failed to download models. Aborting.
[I 231129 13:25:44 launcher:72] ---- Shutting down ----

VoxelCubes commented 9 months ago

That is...very strange. I checked, the file is still being hosted by github in that repository, and deleting my local models and redownloading them with pcleaner worked as expected... Seeing as the error says that max retries was exceeded, that means it attempted to download the file, but couldn't establish a connection, perhaps due to an issue with the internet, maybe github experiencing a brief outage, perhaps?

Does the error still occur, or is it persistent? I'm not too sure what the cause could be, otherwise.

If you have dependency issues with pip, I can recommend getting pipx from pip and use that to install pcleaner. Pipx will place all that into it's own virtualenv on it's own, so no dependency issues. More space, yes, but at least you could then get CUDA, if you happen to have an nvidia GPU. (The binary doesn't contain cuda support, as that would add 5GB by itself, too large for github to host)

Hearing that the binary at least works on Fedora is great news in and of itself, since I've been meaning to build a flatpak for this app using said binary. It'd probably provide an even better user experience for you that way, were it not for this issue.

masiv1001 commented 9 months ago

The errors keeps happening, I will try to use pipx instead of pip, a flatpak version would probably be the best packaging option, I don't know the details but being cross platform, and not dependant on each distro's packages sounds like a good deal, it would open the public being able to use the app (being in a repo like flathub would list is on all the distros that use it as a source)

VoxelCubes commented 9 months ago

Yup, I've gotten my previous package on Flathub already, so I'm familiar with the process, I just need to find the time since it's a rather long, annoying process (though second time should go smoother).

You could also manually download the models and install them to the paths listed by pcleaner. The links pcleaner provides should take you to the right place. The first one is a .pt.onnx (the onnx is the CPU variant) file you get in that repo, and the second one is the whole repo itself.

For the first one you will need to place the comictextdetector.pt.onnx in the .cache/pcleaner/model folder and also update the entry in the config file at .config/pcleaner/pcleanerrc. The entry is: default_cv2_model_path = /home/<username>/.cache/pcleaner/model/comictextdetector.pt.onnx

(You can also use some other path, just gotta set it correctly in the config.)

For the second model, which is a huggingface model, you can look at https://huggingface.co/docs/hub/models-downloading, though I have never tried it myself. It seems a lot more involved, cloning a whole repository and stuff, not just a simple file. Hopefully that one isn't an issue.