search

VoxelCubes / PanelCleaner

An AI-powered tool to clean manga panels.
GNU General Public License v3.0
208 stars 16 forks source link

[DUPLICATE] [Windows] Unicode error with non-ascii letters in a file path #31

Closed iamjosave14202 closed 8 months ago

iamjosave14202 commented 8 months ago

image

iamjosave14202 commented 8 months ago

Output worker encountered an error: <class 'UnicodeDecodeError'>: Traceback (most recent call last): File "pcleaner\gui\worker_thread.py", line 141, in run File "pcleaner\gui\mainwindow_driver.py", line 1064, in generate_output File "pcleaner\gui\processing.py", line 228, in generate_output File "pcleaner\preprocessor.py", line 74, in prep_json_file File "pathlib.py", line 1059, in read_text File "encodings\cp874.py", line 23, in decode UnicodeDecodeError: 'charmap' codec can't decode byte 0x88 in position 350: character maps to 

'charmap' codec can't decode byte 0x88 in position 350: character maps to <undefined>
VoxelCubes commented 8 months ago

Hmm, This appears to be a duplicate of #27 involving windows' weird character encoding messing up the unicode. I need to check where in the pipeline I let Python assume something was unicode without accounting for the possibility of windows doing something strange. As for this issue it's a duplicate of, the guy thankfully provided me with example material to test where this goes wrong. I just need to find the time to investigate properly. I'll have to do that when I get back to a more powerful computer so I can run this in a Windows virtual machine, since the error only happens there.

As for you, I suggest you can rename your image files and/or place them into a different folder such that the full path to the image doesn't contain any non-ascii characters. That'll make it work again until I fix this properly.

VoxelCubes commented 8 months ago

Response to: ummm and Can the text in this image be removed? How do you set it up?

What exactly is the question here? Since it appears to have worked. Any remaining text either wasn't detected, or couldn't be cleaned properly, needing manual work. You can also try tweaking the profile options to make cleaning more/less aggressive.

If you want to save the file as you see it right there, either click on the three dots in the top right and select the save option to export that exact step in the pipeline, or go to the right panel, the box for process, and make sure it's set to cleaning, then press start. Also, make sure the save output checkbox in the output section is enabled, otherwise it won't save any files. If you run the cleaner without it, you can just enable it and run the cleaner again to export.

Hope that helps.

On Sat, Jan 6, 2024, 09:06 Josef Joruno @.***> wrote:

ummm and Can the text in this image be removed? How do you set it up? image.png (view on web)

— Reply to this email directly, view it on GitHub https://github.com/VoxelCubes/PanelCleaner/issues/31#issuecomment-1879589201 . You are receiving this because you modified the open/close state.Message ID: @.***>

VoxelCubes commented 8 months ago

Issue fixed in version 2.1.3. Let me know if it happens again.