VoxelCubes / PanelCleaner

An AI-powered tool to clean manga panels.
GNU General Public License v3.0
202 stars 16 forks source link

[FR] Bulgarian Language Support bg_BG #93

Closed librafrog closed 3 months ago

librafrog commented 3 months ago

Is your feature request related to a problem? Please describe. No

Describe the solution you'd like I would like to create the translation by editing the .ts file. I've forked the project. That's all for know. If I understand correctly if i've built the project from source I can live-check the translation ✔️

Describe alternatives you've considered

Additional context When ready, I'm gonna try to make a pull request to you branch

VoxelCubes commented 3 months ago

That's awesome! Be sure to generate a new .ts file using the makefile though, so that its metadata is correct. No copy pasting and renaming one of the existing ones. If you haven't already, I can do that real quick. I didn't document that step properly.

librafrog commented 3 months ago

yes, if you don't mind generate one. Also will I be able to test if installed from pip and also forked the repo, or the make refresh-assets will not work

VoxelCubes commented 3 months ago

There we go, I had changed something with refresh-assets along the way, which stopped adding new .ts files automatically. So I just fixed that. You will need to fork the repository off of master, then clone that to your local computer. No pip installation for pcleaner, but instead, for the requirements. When inside the project's root directory "PanelCleaner" you'll need to do pip install -r requirements.txt If that worked, then running python pcleaner/main.py will just launch Panel Cleaner from source.

To see bulgarian, you'll need to enable it in the supported languages file as documented. Then after making changes to the .ts file, you will need to make refresh-assets in the terminal. That runs an action from the Makefile. That only works if you have Make installed, which is by default of Linux and probably Macos. For Windows you can alternatively run & "Windows scripts/refresh-assets-windows.bat" (with the &).

I hope it works! Thanks for doing this!

librafrog commented 3 months ago

~all works well, except before actually running refresh assets how to start with the bare bone .ts file.~ I've DW your file and after some changes i use the command in project dir

The system cannot find the path specified.
ECHO is off.
A subdirectory or file translations already exists.
The system cannot find the path specified.
The system cannot find the path specified.
The system cannot find the path specified.
The system cannot find the path specified.
The system cannot find the path specified.
The system cannot find the path specified.
The system cannot find the path specified.
VoxelCubes commented 3 months ago

What does DW mean? Hm, that's very odd. Oh, I think I know what's wrong. The script uses some relative file paths to find the PySide utility programs to do the actual conversion processes, like lupdate.exe, but if you didn't install the dependencies into a directory called venv inside the project directory, you'll need to update them in the script, so it knows where to find them. So either update the paths to the utility programs with wherever they are on your system, or set up a vitual environment called venv in the project root.

Or if it's getting too annoying to set up you can just use crowdin, no setup needed there.