@xmcl/core doesn't recognize Forge

Voxelum / minecraft-launcher-core-node

Provide packages to install Minecraft, launch Minecraft and more to build launcher with NodeJs/Electron!

https://docs.xmcl.app/en/core/

MIT License

174 stars 25 forks source link

@xmcl/core doesn't recognize Forge #241

Closed WeroCode closed 1 year ago

WeroCode commented 2 years ago

Electron version: 20.0.1 (latest)
@xmcl/core version: 2.10.1 (latest)

My code: carbon (1)

Output: MissingVersionJson: ENOENT: no such file or directory, open 'C:\Users\User\AppData\Roaming\.minecraft\versions\1.12.2\1.12.2.json'

Why does @xmcl/core remove everything and leave only "1.12.2"?

WeroCode commented 2 years ago

Interesting fact: with the latest version of Minecraft everything is exactly the same

WeroCode commented 2 years ago

Install Dependencies also does not work, version.parse also gives "1.12.2"

ci010 commented 1 year ago

I need to highlight this in the docs...

The installForge only install forge over a Minecraft version. You need to first await install(aVersion, minecraft); to install the 1.12.2 Minecraft.