search

Voxelum / minecraft-launcher-core-node

Provide packages to install Minecraft, launch Minecraft and more to build launcher with NodeJs/Electron!
https://docs.xmcl.app/en/core/
MIT License
174 stars 25 forks source link

@xmcl/model options not being used #244

Closed John-Dean closed 1 year ago

John-Dean commented 1 year ago

Hello,

The BlockModelFactory .getObject() function takes an optional options param, but this isn't being used anywhere in the code that I can see.

Direct link: https://github.com/Voxelum/minecraft-launcher-core-node/blob/master/packages/model/block.ts#L148

Many thanks, John

John-Dean commented 1 year ago

PR attemping to fix the issue: https://github.com/Voxelum/minecraft-launcher-core-node/pull/248