search

Voxelum / minecraft-launcher-core-node

Provide packages to install Minecraft, launch Minecraft and more to build launcher with NodeJs/Electron!
https://docs.xmcl.app/en/core/
MIT License
174 stars 25 forks source link

eslint changes to fix failing tests #249

Closed John-Dean closed 1 year ago

John-Dean commented 1 year ago

Changed eslint rule from no-duplicate-imports to import/no-duplicates and added in the import plugin required following advice mentioned here: https://github.com/typescript-eslint/typescript-eslint/issues/2315

eslint with --fix has then been run to fix all code issues and pass tests

ci010 commented 1 year ago

I'm working on the stage branch for modern dev experience. It will swap the test framework to vitest, use esbuild to build and change some eslint rule. But thanks for the PR anyway!

ci010 commented 1 year ago

Let's merge this to at least run some test on master