search

Voxelum / minecraft-launcher-core-node

Provide packages to install Minecraft, launch Minecraft and more to build launcher with NodeJs/Electron!
https://docs.xmcl.app/en/core/
MIT License
178 stars 26 forks source link

Incorrect entrypoint for modrinth package #261

Closed encode42 closed 1 year ago

encode42 commented 1 year ago

When attempting to import ModrinthV2Client via the @xmcl/modrinth package in a Qwik project, it does not succeed.

[vite] Internal server error: Failed to resolve entry for package "@xmcl/modrinth". The package may have incorrect main/module/exports specified in its package.json.
  Plugin: vite:import-analysis
  File: [ommitted]/src/routes/index.tsx
      at packageEntryFailure (file://[ommitted]/node_modules/.pnpm/vite@4.2.2_@types+node@18.15.13/node_modules/vite/dist/node/chunks/dep-d305c21f.js:23266:11)
      at resolvePackageEntry (file://[ommitted]/node_modules/.pnpm/vite@4.2.2_@types+node@18.15.13/node_modules/vite/dist/node/chunks/dep-d305c21f.js:23263:5)
      at tryNodeResolve (file://[ommitted]/node_modules/.pnpm/vite@4.2.2_@types+node@18.15.13/node_modules/vite/dist/node/chunks/dep-d305c21f.js:23000:20)
      at Context.resolveId (file://[ommitted]/node_modules/.pnpm/vite@4.2.2_@types+node@18.15.13/node_modules/vite/dist/node/chunks/dep-d305c21f.js:22762:28)
      at Object.resolveId (file://[ommitted]/node_modules/.pnpm/vite@4.2.2_@types+node@18.15.13/node_modules/vite/dist/node/chunks/dep-d305c21f.js:43391:46)
      at async TransformContext.resolve (file://[ommitted]/node_modules/.pnpm/vite@4.2.2_@types+node@18.15.13/node_modules/vite/dist/node/chunks/dep-d305c21f.js:43120:23)
      at async normalizeUrl (file://[ommitted]/node_modules/.pnpm/vite@4.2.2_@types+node@18.15.13/node_modules/vite/dist/node/chunks/dep-d305c21f.js:41447:34)
      at async TransformContext.transform (file://[ommitted]/node_modules/.pnpm/vite@4.2.2_@types+node@18.15.13/node_modules/vite/dist/node/chunks/dep-d305c21f.js:41589:47)
      at async Object.transform (file://[ommitted]/node_modules/.pnpm/vite@4.2.2_@types+node@18.15.13/node_modules/vite/dist/node/chunks/dep-d305c21f.js:43464:30)
      at async loadAndTransform (file://[ommitted]/node_modules/.pnpm/vite@4.2.2_@types+node@18.15.13/node_modules/vite/dist/node/chunks/dep-d305c21f.js:41182:29)

I assume this has to do with the module entrypoint pointing to ./dist/index.mjs, while this file does not exist in the package.

image

ci010 commented 1 year ago

Caused by https://github.com/Voxelum/minecraft-launcher-core-node/blob/master/.github/workflows/release.yml#L35 typo. Will fix today.

ci010 commented 1 year ago

Should be fixed in @xmcl/modrinth@2.0.2

encode42 commented 1 year ago

Indeed it is fixed! Thanks