search

Voxelum / x-minecraft-launcher

An Open Source Minecraft Launcher with Modern UX. Provide a Disk Efficient way to manage all your Mods!
https://xmcl.app/
MIT License
723 stars 105 forks source link

Моды на главном экране #747

Open AIRLord19 opened 2 months ago

AIRLord19 commented 2 months ago

Is there an existing issue for this?

Launcher Version

0.46.1

Operating System

Windows

Architecture

x64

Current Behavior

Не прогружаются картинки модов image

Expected Behavior

No response

Steps To Reproduce

No response

Anything else?

No response

BANSAFAn commented 2 months ago

What's the problem?

AIRLord19 commented 2 months ago

What's the problem?

The images of mods are not loaded. Everything used to be fine.

herosh1sh commented 2 months ago

скорее всего сервер который отвечал за картинки лег, предположений нету больше

66BA9Q-ME49 commented 2 months ago

I have this problem too. I've opened the database which stores mod data such as icons, download URL, description and more (%appdata%\xmcl\resources.sqlite), and it seems the launcher adds these broken icons.

To make it short, mods are identified in this database by the hash of their jar file. In the icons table, there should be only one entry for each hash with the URL of the icon: sha1 icon
bc34ab9d66878d054af37d7b8f914062ba34f4d7 https://cdn.modrinth.com/data/lfHFW1mp/icon.png
9654e78bcdc5d5518fa6b8399e2a133c692421d0 https://media.forgecdn.net/avatars/871/312/638288810018379517.png
But for some reason, the launcher adds a duplicated broken entry for most of the mods which overrides the entry with the valid icon: sha1 icon
08b58bfbdf20660bdc5a0c4a0b088f7d89f40a38 http://launcher/image/7346608cfc16f57672af5ea8c92a803a8f0561db
08b58bfbdf20660bdc5a0c4a0b088f7d89f40a38 https://cdn.modrinth.com/data/6FtRfnLg/icon.png
2c1c81e354f0db938b62735225f02b9a255806a2 http://launcher/image/fa29b0d4af5c8b594799827c6824c59395a60d48
2c1c81e354f0db938b62735225f02b9a255806a2 https://cdn.modrinth.com/data/nvQzSEkH/icon.png
2c1c81e354f0db938b62735225f02b9a255806a2 https://media.forgecdn.net/avatars/207/323/636965628804677340.png

Where all the URLs starting with http://launcher/image/ seem to point to placeholder icons which are the colored circles with a letter inside you can see on the dashboard. Sometimes there are three entries by hash containing the placeholder icon, the mod icon from Curseforge and from Modrinth, as you can see in my table.

I tried to clean up the database by deleting all the duplicated entries, but they are added again each time I start the launcher.

This is not a server error like @herosh1sh suggested in his comment. If you open the links I directly copied from my database, you'll see they point to valid icons.

I hope this bug gets fixed soon!