search

Voxelum / x-minecraft-launcher

An Open Source Minecraft Launcher with Modern UX. Provide a Disk Efficient way to manage all your Mods!
https://xmcl.app/
MIT License
738 stars 107 forks source link

Updating or downgrading mods can create duplicates #816

Open 66BA9Q-ME49 opened 1 month ago

66BA9Q-ME49 commented 1 month ago

Is there an existing issue for this?

Launcher Version

0.47.7

Operating System

Windows

Architecture

x64

Current Behavior

Sometimes, changing the version of a mod from a same source can create duplicates.

Expected Behavior

The version should be switched without leaving the previous version in the mod folder.

Steps To Reproduce

It occurred when downgrading the fabric Replay mod on a forge instance from Modrinth. I also noticed it when updating mods, but I wasn't able to reproduce it. See the video for the steps.

Anything else?

In this video, I'm trying to downgrade the Replay Mod to 2.6.17, and it leaves the 2.16.19 file. Then, when I try to delete the 2.16.19 version, it deletes the 2.16.17 version instead.

https://github.com/user-attachments/assets/f2cceae2-9f5d-4b56-85e8-ee7c936d9199

ci010 commented 1 month ago

Yes this is observed by many people, but it didn't repro in my debug environment. I will keep track this issue