Voxelum / x-minecraft-launcher

An Open Source Minecraft Launcher with Modern UX. Provide a Disk Efficient way to manage all your Mods!
https://xmcl.app/
MIT License
738 stars 107 forks source link

Java location problem #840

Open GyomeiHimejima9906 opened 2 weeks ago

GyomeiHimejima9906 commented 2 weeks ago

Is there an existing issue for this?

Launcher Version

0.47.11

Operating System

Windows

Architecture

x64

Current Behavior

a specify modpack can not be louched dual invalid java path location (but is one modpack that don't start, other modpack start without eny errors)

Expected Behavior

corretly louch

Steps To Reproduce

start the modpack probably it don't start

Anything else?

https://github.com/user-attachments/assets/da8a519f-5ad5-49bb-a285-7ccc64ed7d97 https://github.com/user-attachments/assets/8595990a-0978-4457-afa2-fd4b8e7d4108 (ignore that minecraft don't louch daul incompatible mod set the problem is the modpack that don't start with current java location)

report.zip -0.0.2.zip (exported as modrinth modpack)

ci010 commented 2 weeks ago

I see what's the issue. I should restrict the case user input the instance with space at the start or end of the name.

For your workaround, you can try to rename or duplicate (re-create) this instance, and make sure your instance name does not end with empty space.

ci010 commented 1 week ago

fixed in b98efb99b940b55e34f8086c506472f30e59ede1 and 506a0e2e30dcbb32d0c995215eabd067d6f7d4ad