search

VoyTechnology / CPSSDChat

In VERY early stage of development. PLEASE IGNORE
2 stars 0 forks source link

Moved backend code to new package 'chat'. Also added test. #13

Closed GoldenBadger closed 9 years ago

GoldenBadger commented 9 years ago

Please be very very critical. I know you're not too familiar with Go, so just ask lots of questions. During last year's projects everyone either automatically accepted pull requests or merged their own ones, and that was a really bad thing.

GoldenBadger commented 9 years ago

THANK GOD. Basically the problem was that Travis clones the repo with mixed case while go import paths are always lower case. Therefore, Travis had no idea what the hell was going on.

VoyTechnology commented 9 years ago

Tbh I haven't actually worked with pure Websockets, but looking at MDN's description, what do we put for protocol, if needed?

GoldenBadger commented 9 years ago

You mean in the URL? It'll look like ws://localhost:8080/ or whatever.

VoyTechnology commented 9 years ago

I know about the url, but if you look at

var exampleSocket = new WebSocket("ws://www.example.com/socketserver", "protocolOne");

I am intersted about the protocolOne bit

GoldenBadger commented 9 years ago

I'm not sure. That's more of a client-side thing, from what I can tell. See here.