search

VoylinsGamedevJourney / gozen

The modular video editor
https://youtube.com/@voylinsgamedevjourney
GNU General Public License v3.0
133 stars 20 forks source link

Fix window maximize on windows #79

Closed ManpreetXSingh closed 7 months ago

ManpreetXSingh commented 7 months ago

This PR adds a temporary fix for maximizing the window on windows. I've tested on Windows 11, Fedora KDE and OpenSUSE GNOME. I've tried to keep the code as close to the original as possible. This should allow quick replacement of the code when the issue is fixed in godot itself. There still exist slight issues like the windows 7 style title bar is displayed for 1 frame before the maximizing animation is played. A major drawback of this fix is that get_window().mode does not return Window.MODE_MAXIMIZED even when the window is maximized. As a workaround win_mode variable is implemented with a getter and a setter.

voylin commented 7 months ago

Looks good, thanks for the changes! ^^