Vrekrer / Vrekrer_scpi_parser

Simple SCPI parser for Arduino
MIT License
87 stars 26 forks source link

Refactoring SCPI-Parser #7

Closed Metaln00b closed 4 years ago

Metaln00b commented 4 years ago
Metaln00b commented 4 years ago

Please look at the library code, maybe my version of your scpi parser will only work with ethernet.

Vrekrer commented 4 years ago

Wow, that is a lot of work. Thanks.

But there are some issues:

I think the "example" including temperature and humidity sensor is too complicated to be a library example. For me that is a project using this library and should be listed here https://github.com/Vrekrer/Vrekrer_scpi_parser/issues/5

What do you mean by:

By "Clean up library code", did you mean change the code style? I don't have much time now, but I am still the maintainer of this library and I like the Google C++ style. But if you implement a hash function instead of my "base SCPI_MAX_TOKENS" for GetCommandCode then I let you choose any code style you want.

Can you make small, split commits / pull requests? So I can accept the really good parts (like "Removing compiler warnings") and discuss or review the others.

Metaln00b commented 4 years ago

What do you mean by:

Using serial interface as debug interface

Now responds to non-existing commands ?

I will make all changes to a seperate commits, later.

Vrekrer commented 4 years ago

Compiler warnings are now fixed https://github.com/Vrekrer/Vrekrer_scpi_parser/commit/a8bf670cc8cc964e318b512f59e279e0eae9e052 and some spelling too https://github.com/Vrekrer/Vrekrer_scpi_parser/commit/8e5ede806114c4698f61084b1a448e32b8a05828 Closing this pull request